DescriptionRevert of Reduce plugin_metrics_provider_ usage in MetricsService (https://codereview.chromium.org/308433004/)
Reason for revert:
This CL seems to cause bot failure on CI:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/2745
Original issue's description:
> Reduce plugin_metrics_provider_ usage in MetricsService
>
> This CL eliminates MetricsService's call to
> PluginMetricsProvider::RecordPluginChanges (replaced by a new API on
> MetricsProvider). It additionally adds a
> MetricsServicesManager::OnPluginLoadingError() API and has the plugin observer
> call that API rather than calling MetricsService directly. This change will
> enable easily moving MetricsService::LogPluginLoadingError() to
> ChromeMetricsServiceClient once the latter is the class that keeps a weak
> pointer to the plugin metrics provider.
>
> BUG=375776
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274403
TBR=asvitkine@chromium.org,isherman@chromium.org,jochen@chromium.org,blundell@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=375776
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274418
Patch Set 1 #
Created: 6 years, 6 months ago
(Patch set is too large to download)
Messages
Total messages: 3 (0 generated)
|