Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Issue 314583002: Revert of Reduce plugin_metrics_provider_ usage in MetricsService (Closed)

Created:
6 years, 6 months ago by tzik
Modified:
6 years, 6 months ago
CC:
chromium-reviews, jam, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org, stuartmorgan+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Reduce plugin_metrics_provider_ usage in MetricsService (https://codereview.chromium.org/308433004/) Reason for revert: This CL seems to cause bot failure on CI: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/2745 Original issue's description: > Reduce plugin_metrics_provider_ usage in MetricsService > > This CL eliminates MetricsService's call to > PluginMetricsProvider::RecordPluginChanges (replaced by a new API on > MetricsProvider). It additionally adds a > MetricsServicesManager::OnPluginLoadingError() API and has the plugin observer > call that API rather than calling MetricsService directly. This change will > enable easily moving MetricsService::LogPluginLoadingError() to > ChromeMetricsServiceClient once the latter is the class that keeps a weak > pointer to the plugin metrics provider. > > BUG=375776 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274403 TBR=asvitkine@chromium.org,isherman@chromium.org,jochen@chromium.org,blundell@chromium.org NOTREECHECKS=true NOTRY=true BUG=375776 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274418

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -44 lines) Patch
M chrome/browser/browser_process.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/browser_process_impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/browser_process_impl.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/metrics/metrics_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/metrics/metrics_services_manager.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/metrics/metrics_services_manager.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/metrics/plugin_metrics_provider.h View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/metrics/plugin_metrics_provider.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/plugins/plugin_observer.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/test/base/testing_browser_process.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/base/testing_browser_process.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M components/metrics/metrics_provider.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tzik
Created Revert of Reduce plugin_metrics_provider_ usage in MetricsService
6 years, 6 months ago (2014-06-03 04:37:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/314583002/1
6 years, 6 months ago (2014-06-03 04:38:11 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 04:40:25 UTC) #3
Message was sent while issue was closed.
Change committed as 274418

Powered by Google App Engine
This is Rietveld 408576698