Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 314573005: [dom_distiller] Add support for lookup by URL for InMemoryContentStore. (Closed)

Created:
6 years, 6 months ago by nyquist
Modified:
6 years, 6 months ago
Reviewers:
cjhopman
CC:
chromium-reviews
Visibility:
Public.

Description

[dom_distiller] Add support for lookup by URL for InMemoryContentStore. The InMemoryContentStore currently only supports lookup by entry ID, but this CL adds support for also looking up articles by URLs. This will make the class more usable for when users manually distill web pages. BUG=379642 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275618

Patch Set 1 #

Patch Set 2 : Tiny cleanup #

Patch Set 3 : Rebased #

Total comments: 4

Patch Set 4 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -6 lines) Patch
M components/dom_distiller/core/distilled_content_store.h View 1 2 3 3 chunks +25 lines, -1 line 0 comments Download
M components/dom_distiller/core/distilled_content_store.cc View 1 2 3 3 chunks +54 lines, -1 line 0 comments Download
M components/dom_distiller/core/distilled_content_store_unittest.cc View 5 chunks +94 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
nyquist
cjhopman: PTAL
6 years, 6 months ago (2014-06-03 19:25:50 UTC) #1
cjhopman
https://codereview.chromium.org/314573005/diff/40001/components/dom_distiller/core/distilled_content_store.cc File components/dom_distiller/core/distilled_content_store.cc (right): https://codereview.chromium.org/314573005/diff/40001/components/dom_distiller/core/distilled_content_store.cc#newcode77 components/dom_distiller/core/distilled_content_store.cc:77: std::pair<std::string, std::string>(page.url(), entry.entry_id())); how about just: url_to_id_[page.url()] = entry.entry_id(); ...
6 years, 6 months ago (2014-06-06 17:33:05 UTC) #2
nyquist
cjhopman: PTAL https://codereview.chromium.org/314573005/diff/40001/components/dom_distiller/core/distilled_content_store.cc File components/dom_distiller/core/distilled_content_store.cc (right): https://codereview.chromium.org/314573005/diff/40001/components/dom_distiller/core/distilled_content_store.cc#newcode77 components/dom_distiller/core/distilled_content_store.cc:77: std::pair<std::string, std::string>(page.url(), entry.entry_id())); On 2014/06/06 17:33:05, cjhopman ...
6 years, 6 months ago (2014-06-06 19:00:21 UTC) #3
cjhopman
lgtm
6 years, 6 months ago (2014-06-06 19:30:37 UTC) #4
nyquist
The CQ bit was checked by nyquist@chromium.org
6 years, 6 months ago (2014-06-06 20:10:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/314573005/60001
6 years, 6 months ago (2014-06-06 20:12:01 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 05:04:53 UTC) #7
Message was sent while issue was closed.
Change committed as 275618

Powered by Google App Engine
This is Rietveld 408576698