Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 314573004: Ignore buildtools directory in presubmit.py checks (Closed)

Created:
6 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 6 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Visibility:
Public.

Description

Ignore buildtools directory in presubmit.py checks BUG=none R=machenbach@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=21641

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/presubmit.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 6 months ago (2014-06-03 13:34:05 UTC) #1
Michael Achenbach
lgtm
6 years, 6 months ago (2014-06-03 13:37:50 UTC) #2
jochen (gone - plz use gerrit)
6 years, 6 months ago (2014-06-03 13:38:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21641 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698