Issue 314563003: Handle promotion of ephemeral apps in the ExtensionStorageMonitor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 314563003: Handle promotion of ephemeral apps in the ExtensionStorageMonitor (Closed)

Created:
6 years, 6 months ago by tmdiep

Modified:
6 years, 6 months ago

Reviewers:
koz (OOO until 15th September)

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Handle promotion of ephemeral apps in the ExtensionStorageMonitor Ephemeral apps have a lower initial threshold, which should be increased when they are promoted to regular installed apps. This patch also moves the storaged monitoring related prefs into ExtensionStorageMonitor, as they are specific only to this service. BUG=374018 TEST= browser_tests (ExtensionStorageMonitorTest.*) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274813

Patch Set 1 #

Patch Set 2 : Nit in comment #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+332 lines, -132 lines)			Patch
M	chrome/browser/extensions/extension_storage_monitor.h	View		4 chunks	+46 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/extension_storage_monitor.cc	View	1	13 chunks	+150 lines, -43 lines	0 comments	Download
M	chrome/browser/extensions/extension_storage_monitor_browsertest.cc	View		8 chunks	+136 lines, -25 lines	0 comments	Download
M	extensions/browser/extension_prefs.h	View		1 chunk	+0 lines, -13 lines	0 comments	Download
M	extensions/browser/extension_prefs.cc	View		2 chunks	+0 lines, -47 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

tmdiep

This is part of a bunch of things that need to handle the promotion of ...

6 years, 6 months ago (2014-06-04 05:14:37 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tmdiep@chromium.org/314563003/20001

6 years, 6 months ago (2014-06-04 06:06:07 UTC) #4

Message was sent while issue was closed.

Change committed as 274813

Expand Messages | Collapse Messages