Chromium Code Reviews
Help | Chromium Project | Sign in
(4)

Issue 3145014: Include ICU headers in a way that will also work with use_system_icu=1 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by Paweł Hajdan Jr.
Modified:
4 years ago
CC:
chromium-reviews, brettw-cc_chromium.org, darin-cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Include ICU headers in a way that will also work with use_system_icu=1 TEST=none BUG=28294 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56396

Patch Set 1 #

Patch Set 2 : rebase #

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
4 years, 9 months ago (2010-08-13 21:45:06 UTC) #1
Evan Martin
I'm concerned that these forms of includes will accidentally end up using the system ICU, ...
4 years, 9 months ago (2010-08-13 21:54:50 UTC) #2
Evan Martin
4 years, 9 months ago (2010-08-17 00:56:58 UTC) #3
We talked about this on IRC, and we found that Chrome is already doing the form
of #include I was worrying about all over the place.  So I think my worry is
overstated.

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be