Chromium Code Reviews
Help | Chromium Project | Sign in
(64)

Issue 3145001: FBTF: Clean up task.h in x11_util.h and header usage in some delegates. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by Elliot Glaysher
Modified:
4 years ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, fbarchard, Alpha Left Google, ben+cc_chromium.org, Erik does not do reviews, Paul Godavari, apatrick_chromium, Aaron Boodman, darin-cc_chromium.org, pam+watch_chromium.org, awong (On leave), Paweł Hajdan Jr., brettw-cc_chromium.org, scherkus (very slow to review), nkostylev+cc_chromium.org, John Grabowski, davemoore+watch_chromium.org, amit
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

FBTF: Clean up some headers in tab_contents_delegate.h. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55635

Patch Set 1 #

Patch Set 2 : Fix mac and chromeos compile failures #

Patch Set 3 : More compile fixes #

Patch Set 4 : Win? More liek fail #

Patch Set 5 : Grrr windows not compiling everything #

Patch Set 6 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -14 lines) Patch
M chrome/browser/blocked_popup_container.h View 1 chunk +1 line, -9 lines 0 comments Download
M chrome/browser/blocked_popup_container.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/browser_init_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/frame/panel_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/eula_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/offline/offline_load_page.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/status/clock_menu_button.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/wm_overview_title.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/cocoa/browser_window_cocoa.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/cocoa/content_blocked_bubble_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/cocoa/html_dialog_window_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/cocoa/location_bar/content_setting_decoration.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/cocoa/location_bar/location_bar_view_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/content_setting_bubble_model.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/custom_home_pages_table_model.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/debugger/devtools_sanity_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/dom_ui/new_tab_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/download/download_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/app_process_apitest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/execute_code_in_tab_function.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_browsertests_misc.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_context_menu_model.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_disabled_infobar_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_dom_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_module.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extensions_service.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/about_chrome_dialog.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/browser_actions_toolbar_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/browser_titlebar.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/browser_window_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/download_item_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/extension_install_prompt2_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/extension_install_prompt_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/extension_installed_bubble_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/find_bar_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/gtk_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/html_dialog_gtk.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/gtk/hung_renderer_dialog_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/location_bar_view_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/options/content_page_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/tabs/tab_renderer_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/history/redirect_uitest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/modal_html_dialog_delegate.h View 1 chunk +8 lines, -2 lines 0 comments Download
M chrome/browser/modal_html_dialog_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/speech/speech_input_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/tab_contents/interstitial_page.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_delegate.h View 1 chunk +8 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_delegate.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/task_manager.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/toolbar_model.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/app_launcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/autofill_profiles_view_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/browser_actions_container.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/content_blocked_bubble_contents.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/create_application_shortcut_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/extensions/extension_install_prompt.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/extensions/extension_installed_bubble.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/extensions/extension_shelf.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/html_dialog_view.cc View 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/hung_renderer_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/location_bar/location_bar_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/location_bar/page_action_image_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/options/advanced_contents_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/gpu/gpu_backing_store_glx.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/gpu/gpu_video_layer_glx.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/page_cycler/page_cycler_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/selenium/selenium_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/tab_switching/tab_switching_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/ui/dom_checker_uitest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/ui/dromaeo_benchmark_uitest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/ui/sunspider_uitest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/ui/ui_layout_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/ui/v8_benchmark_uitest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/url_fetch_test/url_fetch_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome_frame/test/perf/chrome_frame_perftest.cc View 1 chunk +1 line, -0 lines 0 comments Download
Trybot results:  win 
Commit: CQ not working?

Messages

Total messages: 4 (0 generated)
Elliot Glaysher
Removing headers from tab_contents_delegate.h has *much* more far reaching influences than it should have. :(
4 years, 9 months ago (2010-08-10 20:50:14 UTC) #1
Lei Zhang
LGTM assuming you fix the Windows build. Ya, that rabbit hole went pretty deep.
4 years, 9 months ago (2010-08-10 20:56:08 UTC) #2
Lei Zhang
Also, the description of this CL is incorrect.
4 years, 9 months ago (2010-08-10 21:33:50 UTC) #3
Elliot Glaysher
4 years, 9 months ago (2010-08-10 21:40:42 UTC) #4
I see what has happened. Somehow that chunk made its way into what I committed
as r55577. Thankfully, this didn't break the tree.

Obviously, I need to stop having six CLs open at a time, working on them all
concurrently.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be