Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 314473002: Add targets for mesa to the GN build. (Closed)

Created:
6 years, 6 months ago by brettw
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add targets for mesa to the GN build. Remove C99 enumation from GYP Windows build now that we have VC2013 R=kbr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274665

Patch Set 1 #

Total comments: 2

Patch Set 2 : git log #

Patch Set 3 : comment out osmesa (still needs work) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+744 lines, -6 lines) Patch
M BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/mesa/BUILD.gn View 1 2 1 chunk +743 lines, -0 lines 0 comments Download
M third_party/mesa/mesa.gyp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
brettw
6 years, 6 months ago (2014-06-02 22:35:49 UTC) #1
Ken Russell (switch to Gerrit)
LGTM modulo one comment. https://codereview.chromium.org/314473002/diff/1/third_party/mesa/mesa.gyp File third_party/mesa/mesa.gyp (left): https://codereview.chromium.org/314473002/diff/1/third_party/mesa/mesa.gyp#oldcode78 third_party/mesa/mesa.gyp:78: # Pick up emulation headers ...
6 years, 6 months ago (2014-06-02 23:13:14 UTC) #2
brettw
https://codereview.chromium.org/314473002/diff/1/third_party/mesa/mesa.gyp File third_party/mesa/mesa.gyp (left): https://codereview.chromium.org/314473002/diff/1/third_party/mesa/mesa.gyp#oldcode78 third_party/mesa/mesa.gyp:78: # Pick up emulation headers not supported by Visual ...
6 years, 6 months ago (2014-06-03 02:17:56 UTC) #3
Ken Russell (switch to Gerrit)
On 2014/06/03 02:17:56, brettw wrote: > https://codereview.chromium.org/314473002/diff/1/third_party/mesa/mesa.gyp > File third_party/mesa/mesa.gyp (left): > > https://codereview.chromium.org/314473002/diff/1/third_party/mesa/mesa.gyp#oldcode78 > ...
6 years, 6 months ago (2014-06-03 02:43:49 UTC) #4
brettw
6 years, 6 months ago (2014-06-03 23:14:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r274665 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698