Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1948)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 314453002: Upload IME Test CRX to latest version. (Closed)

Created:
6 years, 6 months ago by rsadam
Modified:
6 years, 6 months ago
Reviewers:
bshe
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Upload IME Test CRX to latest version. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274542

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -81 lines) Patch
M chrome/browser/chromeos/extensions/input_view_browsertest.cc View 2 chunks +1 line, -8 lines 0 comments Download
M chrome/test/data/chromeos/virtual_keyboard/inputview/GoogleKeyboardInput-xkb.crx View Binary file 0 comments Download
M chrome/test/data/chromeos/virtual_keyboard/inputview/keyset_transition_test.js View 1 chunk +55 lines, -48 lines 0 comments Download
M chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js View 1 5 chunks +63 lines, -18 lines 0 comments Download
M chrome/test/data/chromeos/virtual_keyboard/inputview/typing_test.js View 1 chunk +10 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
rsadam
Hey Biao! PTAL!
6 years, 6 months ago (2014-06-02 20:55:00 UTC) #1
rsadam
Seems it didn't patch correctly. Reuploaded.
6 years, 6 months ago (2014-06-02 21:04:47 UTC) #2
bshe
lgtm with nit. https://codereview.chromium.org/314453002/diff/20001/chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js File chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js (right): https://codereview.chromium.org/314453002/diff/20001/chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js#newcode20 chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js:20: realSetTimeout = setTimeout; nit: window.setTimeout
6 years, 6 months ago (2014-06-03 11:35:26 UTC) #3
rsadam
https://codereview.chromium.org/314453002/diff/20001/chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js File chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js (right): https://codereview.chromium.org/314453002/diff/20001/chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js#newcode20 chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js:20: realSetTimeout = setTimeout; On 2014/06/03 11:35:26, bshe wrote: > ...
6 years, 6 months ago (2014-06-03 13:41:56 UTC) #4
rsadam
The CQ bit was checked by rsadam@chromium.org
6 years, 6 months ago (2014-06-03 13:42:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/314453002/40001
6 years, 6 months ago (2014-06-03 13:44:08 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 16:05:19 UTC) #7
Message was sent while issue was closed. 
Change committed as 274542

Powered by Google App Engine
This is Rietveld 408576698