ash: Make wm::WindowState's c'tor private.

ash: Make wm::WindowState's c'tor private.

wm::WindowState objects should be created via the
wm::GetWindowState() method; they're owned by an
aura::Window and destroyed in the window's d'tor.

BUG=365364
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276013

[Daniel Erat, 2014-06-03 00:14:48]

scott, i'm applying your good suggestion from a few days ago!

[sky, 2014-06-03 13:26:13]

LGTM - thanks

[Daniel Erat, 2014-06-03 14:42:18]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2014-06-03 14:42:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/derat@chromium.org/314433003/20001

[commit-bot: I haz the power, 2014-06-03 16:28:54]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-03 16:31:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-03 16:31:15]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)

[Daniel Erat, 2014-06-03 16:52:11]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2014-06-03 16:52:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/derat@chromium.org/314433003/20001

[commit-bot: I haz the power, 2014-06-03 20:34:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-03 20:34:40]

Failed to apply patch for ash/wm/window_state.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file ash/wm/window_state.cc
  Hunk #1 FAILED at 81.
  Hunk #2 succeeded at 316 (offset 1 line).
  Hunk #3 succeeded at 345 (offset 1 line).
  1 out of 3 hunks FAILED -- saving rejects to file ash/wm/window_state.cc.rej

Patch:       ash/wm/window_state.cc
Index: ash/wm/window_state.cc
diff --git a/ash/wm/window_state.cc b/ash/wm/window_state.cc
index
0b2e674f9596a7c3a73932acc5f84b5beb8d1132..14eba2b1795ed4afc459b1f60690165fc1896727
100644
--- a/ash/wm/window_state.cc
+++ b/ash/wm/window_state.cc
@@ -81,23 +81,6 @@ WMEventType WMEventTypeFromShowState(ui::WindowShowState
requested_show_state) {
 
 }  // namespace
 
-WindowState::WindowState(aura::Window* window)
-    : window_(window),
-      window_position_managed_(false),
-      bounds_changed_by_user_(false),
-      panel_attached_(true),
-      ignored_by_shelf_(false),
-      can_consume_system_keys_(false),
-      top_row_keys_are_function_keys_(false),
-      unminimize_to_restore_bounds_(false),
-      hide_shelf_when_fullscreen_(true),
-      minimum_visibility_(false),
-      can_be_dragged_(true),
-      ignore_property_change_(false),
-      current_state_(new DefaultState(ToWindowStateType(GetShowState()))) {
-  window_->AddObserver(this);
-}
-
 WindowState::~WindowState() {
   // WindowState is registered as an owned property of |window_|, and window
   // unregisters all of its observers in its d'tor before destroying its
@@ -315,6 +298,27 @@ void WindowState::OnWindowPropertyChanged(aura::Window*
window,
   }
 }
 
+WindowState::WindowState(aura::Window* window)
+    : window_(window),
+      window_position_managed_(false),
+      bounds_changed_by_user_(false),
+      panel_attached_(true),
+      ignored_by_shelf_(false),
+      can_consume_system_keys_(false),
+      top_row_keys_are_function_keys_(false),
+      unminimize_to_restore_bounds_(false),
+      hide_shelf_when_fullscreen_(true),
+      minimum_visibility_(false),
+      can_be_dragged_(true),
+      ignore_property_change_(false),
+      current_state_(new DefaultState(ToWindowStateType(GetShowState()))) {
+  window_->AddObserver(this);
+}
+
+ui::WindowShowState WindowState::GetShowState() const {
+  return window_->GetProperty(aura::client::kShowStateKey);
+}
+
 void WindowState::SetBoundsInScreen(
     const gfx::Rect& bounds_in_screen) {
   gfx::Rect bounds_in_parent =
@@ -323,10 +327,6 @@ void WindowState::SetBoundsInScreen(
   window_->SetBounds(bounds_in_parent);
 }
 
-ui::WindowShowState WindowState::GetShowState() const {
-  return window_->GetProperty(aura::client::kShowStateKey);
-}
-
 void WindowState::AdjustSnappedBounds(gfx::Rect* bounds) {
   if (is_dragged() || !IsSnapped())
     return;

[Daniel Erat, 2014-06-03 21:37:27]

merge

[Daniel Erat, 2014-06-03 21:37:39]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2014-06-03 21:39:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/derat@chromium.org/314433003/40001

[commit-bot: I haz the power, 2014-06-04 00:49:27]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[Daniel Erat, 2014-06-09 16:34:45]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2014-06-09 16:36:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/derat@chromium.org/314433003/40001

[commit-bot: I haz the power, 2014-06-10 14:05:49]

Change committed as 276013