Issue 314423003: Fix app_shell CHECK failure on startup on Linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 314423003: Fix app_shell CHECK failure on startup on Linux (Closed)

Created:
6 years, 6 months ago by James Cook

Modified:
6 years, 6 months ago

Reviewers:
Jun Mukai

CC:
chromium-reviews, tfarina, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix app_shell CHECK failure on startup on Linux It needs the input method system initialized. Use a test input method since app_shell on Linux is just a convenience for developers. BUG=381852 TEST=app_shell_browsertests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275590

Patch Set 1 #

Patch Set 2 : cleanup #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	apps/shell/browser/shell_browser_main_parts.cc	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/314423003/20001

6 years, 6 months ago (2014-06-06 21:57:06 UTC) #4

Message was sent while issue was closed.

Change committed as 275590

Expand Messages | Collapse Messages