Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Issue 314393002: Unflake sandboxed-iframe-autofocus-denied.html. (Closed)

Created:
6 years, 6 months ago by dcheng
Modified:
6 years, 6 months ago
Reviewers:
Nate Chapin
CC:
blink-reviews
Visibility:
Public.

Description

Unflake sandboxed-iframe-autofocus-denied.html. The previous version of this test generated non-deterministic results due to the way console messages are generated. Specifically, the test case was constructed while parsing might not yet be complete, but the act of constructing the test case generated console messages. If a console message is generated with no specified line number, Document::internalAddMessage attempts to attach a line number, but one of the conditionals for doing so is whether the Document is still parsing making the output non-deterministic. To get around that, the test has been rewritten to only run once the document is finished loading. BUG=381451 R=japhet@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175706

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -12 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/frames/sandboxed-iframe-autofocus-denied.html View 1 chunk +26 lines, -8 lines 0 comments Download
M LayoutTests/fast/frames/sandboxed-iframe-autofocus-denied-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dcheng
6 years, 6 months ago (2014-06-06 19:05:51 UTC) #1
Nate Chapin
LGTM
6 years, 6 months ago (2014-06-06 19:34:28 UTC) #2
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 6 months ago (2014-06-06 19:44:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/314393002/1
6 years, 6 months ago (2014-06-06 19:45:15 UTC) #4
dcheng
6 years, 6 months ago (2014-06-06 22:06:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r175706 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698