Issue 314373002: Revert "Push API: define push event on Service Worker."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 314373002: Revert "Push API: define push event on Service Worker." (Closed)

Created:
6 years, 6 months ago by ojan

Modified:
6 years, 6 months ago

Reviewers:
Michael van Ouwerkerk

CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Revert "Push API: define push event on Service Worker." This reverts r175672. It breaks the browser_tests compile on Linux (and probably everywhere). ../../third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp:103:74: error: no member named 'push' in namespace 'WebCore::EventTypeNames' m_workerGlobalScope->dispatchEvent(PushEvent::create(EventTypeNames::push, data)); TBR=mvanouwerkerk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175677

Patch Set 1 #

Patch Set 2 : git cl dcommit #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -150 lines)			Patch
M	LayoutTests/webexposed/global-constructors-listing-expected.txt	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/events/EventTypeNames.in	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/modules/modules.gypi	View	4 chunks	+0 lines, -6 lines	0 comments	Download
D	Source/modules/push_messaging/PushEvent.h	View	1 chunk	+0 lines, -51 lines	0 comments	Download
D	Source/modules/push_messaging/PushEvent.cpp	View	1 chunk	+0 lines, -42 lines	0 comments	Download
D	Source/modules/push_messaging/PushEvent.idl	View	1 chunk	+0 lines, -10 lines	0 comments	Download
D	Source/modules/push_messaging/ServiceWorkerGlobalScopePush.h	View	1 chunk	+0 lines, -19 lines	0 comments	Download
D	Source/modules/push_messaging/ServiceWorkerGlobalScopePush.idl	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	Source/web/ServiceWorkerGlobalScopeProxy.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	Source/web/ServiceWorkerGlobalScopeProxy.cpp	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	public/web/WebServiceWorkerContextProxy.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

ojan

6 years, 6 months ago (2014-06-06 17:18:10 UTC) #1

Message was sent while issue was closed.

Committed patchset #2 manually as r175677 (presubmit successful).

Expand Messages | Collapse Messages