Chromium Code Reviews

Unified Diff: Source/modules/filesystem/FileWriter.cpp

Issue 314333002: Enable Oilpan by default in modules/filesystem/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Tidy up Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: Source/modules/filesystem/FileWriter.cpp
diff --git a/Source/modules/filesystem/FileWriter.cpp b/Source/modules/filesystem/FileWriter.cpp
index b352f4c512a96bd7dab48030de4d7517e92a28e0..5f2d070df80c2a083c42dffc121c556f00a5de3a 100644
--- a/Source/modules/filesystem/FileWriter.cpp
+++ b/Source/modules/filesystem/FileWriter.cpp
@@ -46,7 +46,7 @@ static const double progressNotificationIntervalMS = 50;
PassRefPtrWillBeRawPtr<FileWriter> FileWriter::create(ExecutionContext* context)
haraken 2014/06/07 08:11:04 This should be FileWriter*. Since FileWriter is s
sof 2014/06/07 13:18:53 I'm not yet making EventTarget-derived objects liv
haraken 2014/06/07 16:45:27 I think yes. We need to keep FileWriter being RefC
sof 2014/06/08 16:34:34 Thanks for the clarification, that's good. Switche
{
- RefPtrWillBeRawPtr<FileWriter> fileWriter(adoptRefWillBeRefCountedGarbageCollected(new FileWriter(context)));
+ RefPtrWillBeRawPtr<FileWriter> fileWriter(adoptRefCountedGarbageCollected(new FileWriter(context)));
fileWriter->suspendIfNeeded();
return fileWriter.release();
}

Powered by Google App Engine