Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 314303010: Roll Breakpad from 1332 to r1338. (Closed)

Created:
6 years, 6 months ago by justincohen
Modified:
6 years, 6 months ago
Reviewers:
Mark Mentovai, qsr
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Roll Breakpad from 1332 to r1338. This pulls in the following CLs: - r1332 Fix minor typo in a comment in r1331. - r1333 Fix a memory leak in DwarfCUToModule::FuncHandler::Finish(). - r1334 Linux: Fix a memory leak in ExceptionHandler. - r1335 Print more x86-64 registers in minidump_stackwalk - r1336 Add missing MD_MISCINFO_FLAGS1_BUILDSTRING. - r1337 Add virtual dtor to LibcurlWrapper. - r1338 Use PAGE_MAX_SIZE. PAGE_SIZE is now a variable size. BUG=none TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275575

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
justincohen
PTAL!
6 years, 6 months ago (2014-06-06 18:34:11 UTC) #1
justincohen
6 years, 6 months ago (2014-06-06 18:36:49 UTC) #2
qsr
lgtm
6 years, 6 months ago (2014-06-06 18:52:55 UTC) #3
Mark Mentovai
LGTM
6 years, 6 months ago (2014-06-06 18:58:37 UTC) #4
justincohen
The CQ bit was checked by justincohen@chromium.org
6 years, 6 months ago (2014-06-06 19:05:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@chromium.org/314303010/1
6 years, 6 months ago (2014-06-06 19:06:00 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 00:39:20 UTC) #7
Message was sent while issue was closed.
Change committed as 275575

Powered by Google App Engine
This is Rietveld 408576698