Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 314303009: Comments and style nits. (Closed)

Created:
6 years, 6 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 6 months ago
Reviewers:
Noam Samuel, gene
CC:
chromium-reviews
Visibility:
Public.

Description

Comments and style nits. Removed unnecessary static PrivetV3Session::Create method. BUG=372843 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275558

Patch Set 1 #

Patch Set 2 : Fri 06/06/2014 10:48:54.49 #

Patch Set 3 : Fri 06/06/2014 10:50:14.11 #

Total comments: 2

Patch Set 4 : Fri 06/06/2014 11:52:14.02 #

Patch Set 5 : Fri 06/06/2014 11:55:05.73 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -19 lines) Patch
M chrome/browser/local_discovery/privet_http.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/local_discovery/privet_http_asynchronous_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/local_discovery/privetv3_session.h View 1 2 3 1 chunk +25 lines, -14 lines 0 comments Download
M chrome/browser/local_discovery/privetv3_session.cc View 1 2 3 4 1 chunk +15 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 6 months ago (2014-06-06 17:55:39 UTC) #1
gene
https://codereview.chromium.org/314303009/diff/40001/chrome/browser/local_discovery/privetv3_session.h File chrome/browser/local_discovery/privetv3_session.h (right): https://codereview.chromium.org/314303009/diff/40001/chrome/browser/local_discovery/privetv3_session.h#newcode52 chrome/browser/local_discovery/privetv3_session.h:52: void Start() {} why did you remove virtual and ...
6 years, 6 months ago (2014-06-06 18:17:16 UTC) #2
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/314303009/diff/40001/chrome/browser/local_discovery/privetv3_session.h File chrome/browser/local_discovery/privetv3_session.h (right): https://codereview.chromium.org/314303009/diff/40001/chrome/browser/local_discovery/privetv3_session.h#newcode52 chrome/browser/local_discovery/privetv3_session.h:52: void Start() {} On 2014/06/06 18:17:16, gene wrote: > ...
6 years, 6 months ago (2014-06-06 18:52:56 UTC) #3
Noam Samuel
lgtm
6 years, 6 months ago (2014-06-06 18:57:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/314303009/80001
6 years, 6 months ago (2014-06-06 18:57:52 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 00:00:16 UTC) #6
Message was sent while issue was closed. 
Change committed as 275558

Powered by Google App Engine
This is Rietveld 408576698