athena/activity/activity_manager_impl.cc - Issue 314303004: Use webview in web activity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: athena/activity/activity_manager_impl.cc

Issue 314303004: Use webview in web activity (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: added unittests Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: athena/activity/activity_manager_impl.cc

diff --git a/athena/activity/activity_manager_impl.cc b/athena/activity/activity_manager_impl.cc

index 8e37bcae2dfe996080809e15e54ea5357039cf7f..32db67203413b582d056457eff74274cddd5922b 100644

--- a/athena/activity/activity_manager_impl.cc

+++ b/athena/activity/activity_manager_impl.cc

@@ -24,7 +24,7 @@ class ActivityManagerImpl : public ActivityManager {

instance = this;

}

virtual ~ActivityManagerImpl() {

- while (activities_.empty())

+ while (!activities_.empty())

Jun Mukai 2014/06/06 20:17:29 I think this has been fixed by another CL (sorry f

oshima 2014/06/06 20:55:51 I needed this in order for the test to pass. rebas

delete activities_.front();

CHECK_EQ(this, instance);