Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 314303003: [SyncFS] Create SyncWorkerTest (Closed)

Created:
6 years, 6 months ago by peria
Modified:
6 years, 6 months ago
Reviewers:
nhiroki, tzik
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Visibility:
Public.

Description

[SyncFS] Create SyncWorkerTest and add it in unit_tests. Most tests look same between SyncEngineTest and SyncWorkerTest. SyncEngineTest checks communications between SyncEngine and SyncWorker. SyncWorkerTest checks behavior of each method. BUG=378621 TEST=./unit_tests --gtest_filter="SyncEngineTest.*:SyncWorkerTest.*" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275776

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -184 lines) Patch
M chrome/browser/sync_file_system/drive_backend/sync_engine.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine.cc View 2 chunks +0 lines, -41 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc View 14 chunks +14 lines, -67 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_worker.h View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_worker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/sync_file_system/drive_backend/sync_worker_unittest.cc View 8 chunks +72 lines, -66 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
peria
PTL
6 years, 6 months ago (2014-06-06 08:03:25 UTC) #1
tzik
lgtm
6 years, 6 months ago (2014-06-09 03:45:25 UTC) #2
nhiroki
lgtm
6 years, 6 months ago (2014-06-09 04:03:56 UTC) #3
peria
The CQ bit was checked by peria@chromium.org
6 years, 6 months ago (2014-06-09 04:06:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peria@chromium.org/314303003/30001
6 years, 6 months ago (2014-06-09 04:07:01 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-09 05:54:52 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-09 06:25:07 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/149916)
6 years, 6 months ago (2014-06-09 06:25:08 UTC) #8
peria
The CQ bit was checked by peria@chromium.org
6 years, 6 months ago (2014-06-09 06:36:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peria@chromium.org/314303003/30001
6 years, 6 months ago (2014-06-09 06:36:55 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 06:48:17 UTC) #11
Message was sent while issue was closed.
Change committed as 275776

Powered by Google App Engine
This is Rietveld 408576698