Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2019)

Unified Diff: chrome/browser/prerender/prerender_manager.cc

Issue 314293005: Change HistoryService::QueryURL to use CancelableTaskTracker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase & fix style errors Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_manager.cc
diff --git a/chrome/browser/prerender/prerender_manager.cc b/chrome/browser/prerender/prerender_manager.cc
index 85d861ebb3fc60a43cbbc964c10d5ff68c2adb52..aa7551c514049762ea130558a2294c709417fea4 100644
--- a/chrome/browser/prerender/prerender_manager.cc
+++ b/chrome/browser/prerender/prerender_manager.cc
@@ -1373,11 +1373,11 @@ PrerenderHandle* PrerenderManager::AddPrerender(
history_service->QueryURL(
url,
false,
- &query_url_consumer_,
base::Bind(&PrerenderManager::OnHistoryServiceDidQueryURL,
base::Unretained(this),
origin,
- experiment));
+ experiment),
+ &query_url_tracker_);
}
StartSchedulingPeriodicCleanups();
@@ -1852,10 +1852,9 @@ void PrerenderManager::RecordCookieSendType(Origin origin,
void PrerenderManager::OnHistoryServiceDidQueryURL(
Origin origin,
uint8 experiment_id,
- CancelableRequestProvider::Handle handle,
bool success,
- const history::URLRow* url_row,
- history::VisitVector* visists) {
+ const history::URLRow& url_row,
+ const history::VisitVector& visists) {
blundell 2014/06/11 11:08:40 nit: could you rename this to visits while you're
sdefresne 2014/06/11 16:46:25 Done.
histograms_->RecordPrerenderPageVisitedStatus(origin, experiment_id, success);
}

Powered by Google App Engine
This is Rietveld 408576698