chrome/browser/prerender/prerender_manager.cc - Issue 314293005: Change HistoryService::QueryURL to use CancelableTaskTracker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prerender/prerender_manager.cc

Issue 314293005: Change HistoryService::QueryURL to use CancelableTaskTracker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and add comment for scoped_ptr usage Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/history/history_backend.cc ('K') | « chrome/browser/prerender/prerender_manager.h ('k') | chrome/browser/safe_browsing/browser_feature_extractor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/prerender/prerender_manager.cc

diff --git a/chrome/browser/prerender/prerender_manager.cc b/chrome/browser/prerender/prerender_manager.cc

index c6ced3c194eef1dcea336c205d5fd75937c72a81..62ed58d561c5d2e16e63c431673f2fb424053c0d 100644

--- a/chrome/browser/prerender/prerender_manager.cc

+++ b/chrome/browser/prerender/prerender_manager.cc

@@ -1373,11 +1373,11 @@ PrerenderHandle* PrerenderManager::AddPrerender(

history_service->QueryURL(

url,

false,

- &query_url_consumer_,

base::Bind(&PrerenderManager::OnHistoryServiceDidQueryURL,

base::Unretained(this),

origin,

- experiment));

+ experiment),

+ &query_url_tracker_);

}

StartSchedulingPeriodicCleanups();

@@ -1852,10 +1852,9 @@ void PrerenderManager::RecordCookieSendType(Origin origin,

void PrerenderManager::OnHistoryServiceDidQueryURL(

Origin origin,

uint8 experiment_id,

- CancelableRequestProvider::Handle handle,

bool success,

- const history::URLRow* url_row,

- history::VisitVector* visists) {

+ const history::URLRow& url_row,

+ const history::VisitVector& /*visits*/) {

histograms_->RecordPrerenderPageVisitedStatus(origin, experiment_id, success);

}