chrome/browser/extensions/api/history/history_api.h - Issue 314293005: Change HistoryService::QueryURL to use CancelableTaskTracker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/history/history_api.h

Issue 314293005: Change HistoryService::QueryURL to use CancelableTaskTracker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and add comment for scoped_ptr usage Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/custom_home_pages_table_model.cc ('K') | « chrome/browser/custom_home_pages_table_model.cc ('k') | chrome/browser/extensions/api/history/history_api.cc » ('j') | chrome/browser/history/history_backend.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/history/history_api.h

diff --git a/chrome/browser/extensions/api/history/history_api.h b/chrome/browser/extensions/api/history/history_api.h

index 32040b5645ccb0878cba3695d21d5bf06fc4032a..cd1e9427a0281f8a1e1f5ad24c39a6169c23da82 100644

--- a/chrome/browser/extensions/api/history/history_api.h

+++ b/chrome/browser/extensions/api/history/history_api.h

@@ -135,10 +135,9 @@ class HistoryGetVisitsFunction : public HistoryFunctionWithCallback {

virtual bool RunAsyncImpl() OVERRIDE;

// Callback for the history function to provide results.

- void QueryComplete(HistoryService::Handle request_service,

- bool success,

- const history::URLRow* url_row,

- history::VisitVector* visits);

+ void QueryComplete(bool success,

+ const history::URLRow& url_row,

+ const history::VisitVector& visits);

};

class HistorySearchFunction : public HistoryFunctionWithCallback {