Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1906)

Unified Diff: chrome/browser/browsing_data/browsing_data_remover_unittest.cc

Issue 314293005: Change HistoryService::QueryURL to use CancelableTaskTracker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and add comment for scoped_ptr usage Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/browsing_data_remover_unittest.cc
diff --git a/chrome/browser/browsing_data/browsing_data_remover_unittest.cc b/chrome/browser/browsing_data/browsing_data_remover_unittest.cc
index 349ae04b1bda62422d0a3c60c66d8ee5394520a7..29c3595f51a593a617ea1b6e87af0a29809eed9c 100644
--- a/chrome/browser/browsing_data/browsing_data_remover_unittest.cc
+++ b/chrome/browser/browsing_data/browsing_data_remover_unittest.cc
@@ -15,6 +15,7 @@
#include "base/message_loop/message_loop.h"
#include "base/prefs/testing_pref_service.h"
#include "base/strings/utf_string_conversions.h"
+#include "base/task/cancelable_task_tracker.h"
#include "chrome/browser/autofill/personal_data_manager_factory.h"
#include "chrome/browser/browsing_data/browsing_data_helper.h"
#include "chrome/browser/browsing_data/browsing_data_remover_test_util.h"
@@ -384,9 +385,9 @@ class RemoveHistoryTester {
history_service_->QueryURL(
url,
true,
- &consumer_,
base::Bind(&RemoveHistoryTester::SaveResultAndQuit,
- base::Unretained(this)));
+ base::Unretained(this)),
+ &tracker_);
message_loop_runner->Run();
return query_url_success_;
}
@@ -399,16 +400,15 @@ class RemoveHistoryTester {
private:
// Callback for HistoryService::QueryURL.
- void SaveResultAndQuit(HistoryService::Handle,
- bool success,
- const history::URLRow*,
- history::VisitVector*) {
+ void SaveResultAndQuit(bool success,
+ const history::URLRow&,
+ const history::VisitVector&) {
query_url_success_ = success;
quit_closure_.Run();
}
// For History requests.
- CancelableRequestConsumer consumer_;
+ base::CancelableTaskTracker tracker_;
bool query_url_success_;
base::Closure quit_closure_;
« no previous file with comments | « no previous file | chrome/browser/custom_home_pages_table_model.h » ('j') | chrome/browser/custom_home_pages_table_model.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698