[Storage] Normalize storage partition path before garbage collection

content/browser/storage_partition_impl_map.h

Index: content/browser/storage_partition_impl_map.h
diff --git a/content/browser/storage_partition_impl_map.h b/content/browser/storage_partition_impl_map.h
index 972335a33aaab0b6cedebd7ea7dc46cb567ffb1d..feb31200a854d2c82d67f381b1f163fa18edf4fa 100644
--- a/content/browser/storage_partition_impl_map.h
+++ b/content/browser/storage_partition_impl_map.h
@@ -27,9 +27,10 @@ class BrowserContext;
 // A std::string to StoragePartition map for use with SupportsUserData APIs.
 class StoragePartitionImplMap : public base::SupportsUserData::Data {
  public:
-  explicit StoragePartitionImplMap(BrowserContext* browser_context);
+  CONTENT_EXPORT explicit StoragePartitionImplMap(

[sky, 2014/06/06 16:10:06]

To my knowledge we generally don't export individual methods, only the class. Is
there a reason you aren't doing that here?

[tzik, 2014/06/06 17:25:20]

Just following StoragePartitionImpl does. I have no strong opinion for that.
https://chromium.googlesource.com/chromium/src/+/63b1b7ed9071c74bf0d9345321a4...

+      BrowserContext* browser_context);
 
-  virtual ~StoragePartitionImplMap();
+  CONTENT_EXPORT virtual ~StoragePartitionImplMap();
 
   // This map retains ownership of the returned StoragePartition objects.
   StoragePartitionImpl* Get(const std::string& partition_domain,
@@ -50,13 +51,15 @@ class StoragePartitionImplMap : public base::SupportsUserData::Data {
   //
   // The |done| closure is executed on the calling thread when garbage
   // collection is complete.
-  void GarbageCollect(scoped_ptr<base::hash_set<base::FilePath> > active_paths,
-                      const base::Closure& done);
+  CONTENT_EXPORT void GarbageCollect(
+      scoped_ptr<base::hash_set<base::FilePath> > active_paths,
+      const base::Closure& done);
 
   void ForEach(const BrowserContext::StoragePartitionCallback& callback);
 
  private:
   FRIEND_TEST_ALL_PREFIXES(StoragePartitionConfigTest, OperatorLess);
+  FRIEND_TEST_ALL_PREFIXES(StoragePartitionImplMapTest, GarbageCollect);
 
   // Each StoragePartition is uniquely identified by which partition domain
   // it belongs to (such as an app or the browser itself), the user supplied
@@ -105,7 +108,7 @@ class StoragePartitionImplMap : public base::SupportsUserData::Data {
   // Returns the relative path from the profile's base directory, to the
   // directory that holds all the state for storage contexts in the given
   // |partition_domain| and |partition_name|.
-  static base::FilePath GetStoragePartitionPath(
+  CONTENT_EXPORT static base::FilePath GetStoragePartitionPath(
       const std::string& partition_domain,
       const std::string& partition_name);