Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 314293003: [Storage] Normalize storage partition path before garbage collection (Closed)

Created:
6 years, 6 months ago by tzik
Modified:
6 years, 6 months ago
Reviewers:
sky, awong
CC:
chromium-reviews, darin-cc_chromium.org, jam, imskull_gmail.com, Yusuke Sato
Visibility:
Public.

Description

[Storage] Normalize storage partition path before garbage collection Protect |active_paths| from garbage collection even when they are not direct subdirectories of |storage_root|. BUG=328637 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275662

Patch Set 1 #

Patch Set 2 : enable fix #

Patch Set 3 : polish #

Total comments: 2

Patch Set 4 : export StoragePartitionImplMap #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -5 lines) Patch
M content/browser/storage_partition_impl_map.h View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/storage_partition_impl_map.cc View 1 2 chunks +23 lines, -0 lines 0 comments Download
M content/browser/storage_partition_impl_map_unittest.cc View 1 2 2 chunks +33 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tzik
PTL. PatchSet 1 should reveal the issue and 2 should fix it.
6 years, 6 months ago (2014-06-06 13:13:23 UTC) #1
sky
https://codereview.chromium.org/314293003/diff/40001/content/browser/storage_partition_impl_map.h File content/browser/storage_partition_impl_map.h (right): https://codereview.chromium.org/314293003/diff/40001/content/browser/storage_partition_impl_map.h#newcode30 content/browser/storage_partition_impl_map.h:30: CONTENT_EXPORT explicit StoragePartitionImplMap( To my knowledge we generally don't ...
6 years, 6 months ago (2014-06-06 16:10:06 UTC) #2
tzik
https://codereview.chromium.org/314293003/diff/40001/content/browser/storage_partition_impl_map.h File content/browser/storage_partition_impl_map.h (right): https://codereview.chromium.org/314293003/diff/40001/content/browser/storage_partition_impl_map.h#newcode30 content/browser/storage_partition_impl_map.h:30: CONTENT_EXPORT explicit StoragePartitionImplMap( On 2014/06/06 16:10:06, sky wrote: > ...
6 years, 6 months ago (2014-06-06 17:25:21 UTC) #3
sky
LGTM
6 years, 6 months ago (2014-06-06 19:46:56 UTC) #4
awong
LGTM as well
6 years, 6 months ago (2014-06-06 20:27:34 UTC) #5
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 6 months ago (2014-06-07 02:12:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/314293003/60001
6 years, 6 months ago (2014-06-07 02:13:38 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 09:03:06 UTC) #8
Message was sent while issue was closed. 
Change committed as 275662

Powered by Google App Engine
This is Rietveld 408576698