Issue 314293002: Mojo: Add a trivial end-to-end (in-process) test of Mojo shell.

Issue 314293002: Mojo: Add a trivial end-to-end (in-process) test of Mojo shell. (Closed)

Created:
6 years, 6 months ago by viettrungluu

Modified:
6 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mojo: Add a trivial end-to-end (in-process) test of Mojo shell. Loads a test service and pings it (and then quits). R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275829

Patch Set 2 : review comments #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+231 lines, -12 lines)			Patch
M	mojo/mojo.gyp	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	mojo/mojo_services.gypi	View	1	1 chunk	+33 lines, -0 lines	0 comments	Download
A +	mojo/services/test_service/test_service.mojom	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
A	mojo/services/test_service/test_service_application.cc	View	1	1 chunk	+34 lines, -0 lines	0 comments	Download
A	mojo/services/test_service/test_service_impl.h	View		1 chunk	+26 lines, -0 lines	0 comments	Download
A +	mojo/services/test_service/test_service_impl.cc	View		1 chunk	+7 lines, -5 lines	0 comments	Download
M	mojo/shell/shell_test_base.h	View		2 chunks	+31 lines, -3 lines	0 comments	Download
M	mojo/shell/shell_test_base.cc	View		2 chunks	+38 lines, -0 lines	0 comments	Download
A	mojo/shell/shell_test_base_unittest.cc	View		1 chunk	+55 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/314293002/diff/1/mojo/services/test_service/application.cc File mojo/services/test_service/application.cc (right): https://codereview.chromium.org/314293002/diff/1/mojo/services/test_service/application.cc#newcode10 mojo/services/test_service/application.cc:10: nit: remove empty newline. https://codereview.chromium.org/314293002/diff/1/mojo/services/test_service/application.cc#newcode14 mojo/services/test_service/application.cc:14: class TestServiceApplication ...

6 years, 6 months ago (2014-06-06 00:02:00 UTC) #2

viettrungluu

Thanks. https://codereview.chromium.org/314293002/diff/1/mojo/services/test_service/application.cc File mojo/services/test_service/application.cc (right): https://codereview.chromium.org/314293002/diff/1/mojo/services/test_service/application.cc#newcode10 mojo/services/test_service/application.cc:10: On 2014/06/06 00:02:00, sky wrote: > nit: remove ...

6 years, 6 months ago (2014-06-09 16:56:35 UTC) #3

viettrungluu

6 years, 6 months ago (2014-06-09 17:24:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r275829 (presubmit successful).

Expand Messages | Collapse Messages