Remove m_requestEntityBody from XMLHttpRequest

Remove m_requestEntityBody from XMLHttpRequest

We don't have to hold the FormData instance to be used by createRequest()
as a class member. It's instantiated right before createRequest() call.
We can just allocate it on stack.

BUG=none
R=ricea,tkent

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175776

[Adam Rice, 2014-06-06 12:57:14]

lgtm

[tyoshino (SeeGerritForStatus), 2014-06-09 04:17:09]

Thanks Adam. I just added release() calls not to unnecessarily keep a reference
to FormData.

[tyoshino (SeeGerritForStatus), 2014-06-09 04:17:22]

+tkent for OWNER review

[tyoshino (SeeGerritForStatus), 2014-06-09 04:17:58]

On 2014/06/09 04:17:22, tyoshino wrote:
> +tkent for OWNER review

and cc abarth

[tkent, 2014-06-09 04:39:05]

https://codereview.chromium.org/314283005/diff/20001/Source/core/xml/XMLHttpR...
File Source/core/xml/XMLHttpRequest.cpp (right):

https://codereview.chromium.org/314283005/diff/20001/Source/core/xml/XMLHttpR...
Source/core/xml/XMLHttpRequest.cpp:823: if (httpBody.get() && m_upload) {
nit: |.get()| is unnecessary.

https://codereview.chromium.org/314283005/diff/20001/Source/core/xml/XMLHttpR...
Source/core/xml/XMLHttpRequest.cpp:842:
InspectorInstrumentation::willLoadXHR(&executionContext, this, this, m_method,
m_url, m_async, httpBody.get() ? httpBody->deepCopy() : nullptr,
m_requestHeaders, m_includeCredentials);
nit: |.get()| is unnecessary.

https://codereview.chromium.org/314283005/diff/20001/Source/core/xml/XMLHttpR...
Source/core/xml/XMLHttpRequest.cpp:844: if (httpBody.get()) {
Ditto.

[tkent, 2014-06-09 04:39:10]

lgtm

[tyoshino (SeeGerritForStatus), 2014-06-09 04:52:30]

https://codereview.chromium.org/314283005/diff/20001/Source/core/xml/XMLHttpR...
File Source/core/xml/XMLHttpRequest.cpp (right):

https://codereview.chromium.org/314283005/diff/20001/Source/core/xml/XMLHttpR...
Source/core/xml/XMLHttpRequest.cpp:823: if (httpBody.get() && m_upload) {
On 2014/06/09 04:39:05, tkent wrote:
> nit: |.get()| is unnecessary.

Done.

https://codereview.chromium.org/314283005/diff/20001/Source/core/xml/XMLHttpR...
Source/core/xml/XMLHttpRequest.cpp:842:
InspectorInstrumentation::willLoadXHR(&executionContext, this, this, m_method,
m_url, m_async, httpBody.get() ? httpBody->deepCopy() : nullptr,
m_requestHeaders, m_includeCredentials);
On 2014/06/09 04:39:05, tkent wrote:
> nit: |.get()| is unnecessary.

Done.

https://codereview.chromium.org/314283005/diff/20001/Source/core/xml/XMLHttpR...
Source/core/xml/XMLHttpRequest.cpp:844: if (httpBody.get()) {
On 2014/06/09 04:39:05, tkent wrote:
> Ditto.

Done.

[tyoshino (SeeGerritForStatus), 2014-06-09 04:52:49]

The CQ bit was checked by tyoshino@chromium.org

[tyoshino (SeeGerritForStatus), 2014-06-09 04:52:52]

The CQ bit was unchecked by tyoshino@chromium.org

[tyoshino (SeeGerritForStatus), 2014-06-09 04:53:10]

The CQ bit was checked by tyoshino@chromium.org

[commit-bot: I haz the power, 2014-06-09 04:54:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tyoshino@chromium.org/314283005/40001

[commit-bot: I haz the power, 2014-06-09 05:57:56]

Change committed as 175776