Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 314203002: Fix for authenticating to internal repos (Closed)

Created:
6 years, 6 months ago by hinoka
Modified:
6 years, 6 months ago
Reviewers:
Ryan Tseng, agable, iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Fix for authenticating to internal repos Last patch (https://codereview.chromium.org/313933005/) forgot to take into account using a boto file (setting boto to os.devnull means connect unauthenticated, setting it to None will allow it to do the default behavior) This patch will always use a boto file, which should be fine. BUG=261741 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=275230

Patch Set 1 #

Patch Set 2 : Actually just authenticate all the time #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M git_cache.py View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hinoka
6 years, 6 months ago (2014-06-05 19:13:32 UTC) #1
iannucci
lgtm
6 years, 6 months ago (2014-06-05 19:35:05 UTC) #2
Ryan Tseng
The CQ bit was checked by hinoka@google.com
6 years, 6 months ago (2014-06-05 20:17:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@chromium.org/314203002/20001
6 years, 6 months ago (2014-06-05 20:17:58 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 20:20:05 UTC) #5
Message was sent while issue was closed.
Change committed as 275230

Powered by Google App Engine
This is Rietveld 408576698