Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 314193002: Split SkFontHost_win_dw. (Closed)

Created:
6 years, 6 months ago by bungeman-skia
Modified:
6 years, 6 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Split SkFontHost_win_dw. Split SkFontHost_win_dw into FontMgr, Typeface, and ScalerContext. This makes working on these files easier, and moves away from the legacy FontHost naming. Committed: https://skia.googlesource.com/skia/+/51daa25a2b16bca578e78b7ea1e5815b9abb8b0b

Patch Set 1 #

Patch Set 2 : Remove unneeded includes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1494 lines, -1408 lines) Patch
M gyp/ports.gyp View 2 chunks +8 lines, -0 lines 0 comments Download
M src/ports/SkFontHost_win_dw.cpp View 1 3 chunks +3 lines, -1408 lines 0 comments Download
A src/ports/SkFontMgr_win_dw.cpp View 1 chunk +774 lines, -0 lines 0 comments Download
A src/ports/SkScalerContext_win_dw.h View 1 chunk +63 lines, -0 lines 0 comments Download
A src/ports/SkTypeface_win_dw.h View 1 chunk +109 lines, -0 lines 0 comments Download
A src/ports/SkTypeface_win_dw.cpp View 1 chunk +499 lines, -0 lines 0 comments Download
M src/utils/win/SkDWrite.h View 2 chunks +38 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bungeman-skia
As much as possible, this is a simple code re-organization with as few code changes ...
6 years, 6 months ago (2014-06-05 18:47:56 UTC) #1
reed1
lgtm
6 years, 6 months ago (2014-06-05 19:41:42 UTC) #2
bungeman-skia
The CQ bit was checked by bungeman@google.com
6 years, 6 months ago (2014-06-05 20:14:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/314193002/20001
6 years, 6 months ago (2014-06-05 20:16:07 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 20:38:50 UTC) #5
Message was sent while issue was closed.
Change committed as 51daa25a2b16bca578e78b7ea1e5815b9abb8b0b

Powered by Google App Engine
This is Rietveld 408576698