Issue 314183002: Cache network icon urls

Issue 314183002: Cache network icon urls (Closed)

Created:
6 years, 6 months ago by stevenjb

Modified:
6 years, 6 months ago

Reviewers:
Nikita (slow), jennyz

CC:
chromium-reviews, dbeam+watch-options_chromium.org, sadrul, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Cache network icon urls Encoding icons to urls for WebUI is expensive enough that we should do some basic caching to avoid redundant encoding calls. BUG=336385 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275504

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rebase + Address feedback #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+153 lines, -38 lines)			Patch
M	ash/system/chromeos/network/network_icon.h	View		2 chunks	+13 lines, -0 lines	0 comments	Download
M	ash/system/chromeos/network/network_icon.cc	View	1	10 chunks	+133 lines, -26 lines	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc	View		3 chunks	+7 lines, -12 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

lgtm, thanks https://codereview.chromium.org/314183002/diff/1/ash/system/chromeos/network/network_icon.cc File ash/system/chromeos/network/network_icon.cc (right): https://codereview.chromium.org/314183002/diff/1/ash/system/chromeos/network/network_icon.cc#newcode118 ash/system/chromeos/network/network_icon.cc:118: typedef std::map<float, std::string> ImageUrlMap; nit: Move typedef ...

6 years, 6 months ago (2014-06-06 16:17:26 UTC) #2

stevenjb

https://codereview.chromium.org/314183002/diff/1/ash/system/chromeos/network/network_icon.cc File ash/system/chromeos/network/network_icon.cc (right): https://codereview.chromium.org/314183002/diff/1/ash/system/chromeos/network/network_icon.cc#newcode118 ash/system/chromeos/network/network_icon.cc:118: typedef std::map<float, std::string> ImageUrlMap; On 2014/06/06 16:17:26, Nikita Kostylev ...

6 years, 6 months ago (2014-06-06 16:44:56 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/314183002/20001

6 years, 6 months ago (2014-06-06 16:46:20 UTC) #5

Message was sent while issue was closed.

Change committed as 275504

Expand Messages | Collapse Messages