Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 314173005: Revert of Convert installer_util_unittests, sbox_integration_tests, sbox_validation_tests, sbox_unittests to … (Closed)

Created:
6 years, 6 months ago by alph
Modified:
6 years, 6 months ago
CC:
chromium-reviews, grt+watch_chromium.org, erikwright+watch_chromium.org
Visibility:
Public.

Description

Revert of Convert installer_util_unittests, sbox_integration_tests, sbox_validation_tests, sbox_unittests to … (https://codereview.chromium.org/315403006/) Reason for revert: Broke a bunch of unit tests on Win. http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/19568 Original issue's description: > Convert installer_util_unittests, sbox_integration_tests, sbox_validation_tests, sbox_unittests to new test launcher > > Also add them to the Windows trybots > > BUG=381071 > R=grt@chromium.org, rvargas@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275801 TBR=gab@chromium.org,rvargas@chromium.org,grt@chromium.org,phajdan.jr@chromium.org NOTREECHECKS=true NOTRY=true BUG=381071 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275805

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -201 lines) Patch
M base/test/launcher/test_launcher.h View 3 chunks +20 lines, -5 lines 0 comments Download
M base/test/launcher/test_launcher.cc View 9 chunks +40 lines, -36 lines 0 comments Download
M base/test/launcher/unit_test_launcher.h View 1 chunk +0 lines, -9 lines 0 comments Download
M base/test/launcher/unit_test_launcher.cc View 8 chunks +13 lines, -51 lines 0 comments Download
M base/test/test_suite.h View 2 chunks +1 line, -9 lines 0 comments Download
M base/test/test_suite.cc View 3 chunks +14 lines, -35 lines 0 comments Download
M chrome/installer/util/run_all_unittests.cc View 2 chunks +1 line, -8 lines 0 comments Download
M content/public/test/test_launcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sandbox/win/sandbox_win.gypi View 3 chunks +0 lines, -3 lines 0 comments Download
M sandbox/win/tests/integration_tests/integration_tests.cc View 2 chunks +2 lines, -9 lines 0 comments Download
M sandbox/win/tests/unit_tests/unit_tests.cc View 2 chunks +2 lines, -9 lines 0 comments Download
M sandbox/win/tests/validation_tests/unit_tests.cc View 2 chunks +2 lines, -9 lines 0 comments Download
M testing/buildbot/chromium_trybot.json View 2 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
alph
Created Revert of Convert installer_util_unittests, sbox_integration_tests, sbox_validation_tests, sbox_unittests to …
6 years, 6 months ago (2014-06-09 14:43:58 UTC) #1
alph
6 years, 6 months ago (2014-06-09 14:49:52 UTC) #2
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/327543002/ by alph@chromium.org.

The reason for reverting is: Looks like it was a flake..

Powered by Google App Engine
This is Rietveld 408576698