net/proxy/proxy_service.h - Issue 314173002: Bypass data reduction proxy if no handler is found for a 407 error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_service.h

Issue 314173002: Bypass data reduction proxy if no handler is found for a 407 error. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@benpatch

Patch Set: Added TODO as suggested by bengr. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/common/data_reduction_proxy_headers_unittest.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/proxy/proxy_service.h

diff --git a/net/proxy/proxy_service.h b/net/proxy/proxy_service.h

index 6f8556879f67fb00fe28bdaa312a0a5bd81c7926..269f1c04522119397f1ce49e7d80e1a16594706d 100644

--- a/net/proxy/proxy_service.h

+++ b/net/proxy/proxy_service.h

@@ -292,6 +292,9 @@ class NET_EXPORT ProxyService : public NetworkChangeNotifier::IPAddressObserver,

// Bypass the proxy because the proxy, not the origin, sent a 4xx response.

PROXY_4XX_BYPASS,

+ // Bypass the proxy because we got a 407 from the proxy without a challenge.

+ MALFORMED_407_BYPASS,

// This must always be last.

BYPASS_EVENT_TYPE_MAX

};