Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: components/data_reduction_proxy/common/data_reduction_proxy_headers.cc

Issue 314173002: Bypass data reduction proxy if no handler is found for a 407 error. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@benpatch
Patch Set: Added TODO as suggested by bengr. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/data_reduction_proxy/common/data_reduction_proxy_headers_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/data_reduction_proxy/common/data_reduction_proxy_headers.cc
diff --git a/components/data_reduction_proxy/common/data_reduction_proxy_headers.cc b/components/data_reduction_proxy/common/data_reduction_proxy_headers.cc
index c7775c81216f46579e772a3b56357031133cef20..4bc902532c980f5ff94ffc9af1913f23a9dfc989 100644
--- a/components/data_reduction_proxy/common/data_reduction_proxy_headers.cc
+++ b/components/data_reduction_proxy/common/data_reduction_proxy_headers.cc
@@ -121,6 +121,12 @@ GetDataReductionProxyBypassEventType(
// Fall back if a 500, 502 or 503 is returned.
return ProxyService::INTERNAL_SERVER_ERROR_BYPASS;
}
+ // TODO(kundaji): Bypass if Proxy-Authenticate header value cannot be
+ // interpreted by data reduction proxy.
+ if (headers->response_code() == net::HTTP_PROXY_AUTHENTICATION_REQUIRED &&
+ !headers->HasHeader("Proxy-Authenticate")) {
+ return ProxyService::MALFORMED_407_BYPASS;
+ }
if (!IsDataReductionProxyResponse(headers) &&
(headers->response_code() != net::HTTP_NOT_MODIFIED)) {
// A Via header might not be present in a 304. Since the goal of a 304
« no previous file with comments | « no previous file | components/data_reduction_proxy/common/data_reduction_proxy_headers_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698