components/data_reduction_proxy/common/data_reduction_proxy_headers_unittest.cc - Issue 314173002: Bypass data reduction proxy if no handler is found for a 407 error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/common/data_reduction_proxy_headers_unittest.cc

Issue 314173002: Bypass data reduction proxy if no handler is found for a 407 error. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@benpatch

Patch Set: Added unit tests. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/data_reduction_proxy/common/data_reduction_proxy_headers.cc ('K') | « components/data_reduction_proxy/common/data_reduction_proxy_headers.cc ('k') | net/proxy/proxy_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/common/data_reduction_proxy_headers_unittest.cc

diff --git a/components/data_reduction_proxy/common/data_reduction_proxy_headers_unittest.cc b/components/data_reduction_proxy/common/data_reduction_proxy_headers_unittest.cc

index 1965b9866faf1ddd0e050c7d4d94201f8334a686..1ebb7fe4c1a649e79d2686f4b2e732884f82f554 100644

--- a/components/data_reduction_proxy/common/data_reduction_proxy_headers_unittest.cc

+++ b/components/data_reduction_proxy/common/data_reduction_proxy_headers_unittest.cc

@@ -337,6 +337,14 @@ TEST_F(DataReductionProxyHeadersTest, GetDataReductionProxyBypassEventType) {

{ "HTTP/1.1 414 Request-URI Too Long\n"

"Via: 1.1 Chrome-Compression-Proxy\n",

net::ProxyService::BYPASS_EVENT_TYPE_MAX,

+ },

+ { "HTTP/1.1 407 Proxy Authentication Required\n",

+ net::ProxyService::MALFORMED_407_BYPASS,

+ },

+ { "HTTP/1.1 407 Proxy Authentication Required\n"

+ "Proxy-Authenticate: Basic\n"

+ "Via: 1.1 Chrome-Compression-Proxy\n",

+ net::ProxyService::BYPASS_EVENT_TYPE_MAX,

}

};

for (size_t i = 0; i < ARRAYSIZE_UNSAFE(tests); ++i) {