Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 314123002: Fixed string conversions to avoid nil pointers. (Closed)

Created:
6 years, 6 months ago by pkl (ping after 24h if needed)
Modified:
6 years, 6 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, noyau (Ping after 24h)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fixed string conversions to avoid nil pointers. base_unittests was failing on iOS 6 devices. This fixes it. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275227

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M base/ios/device_util.h View 1 chunk +1 line, -1 line 0 comments Download
M base/ios/device_util.mm View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
pkl (ping after 24h if needed)
6 years, 6 months ago (2014-06-05 14:23:33 UTC) #1
rohitrao (ping after 24h)
LGTM Why wasn't this failing on iOS7 too?
6 years, 6 months ago (2014-06-05 14:27:43 UTC) #2
pkl (ping after 24h if needed)
On 2014/06/05 14:27:43, rohitrao wrote: > LGTM > > Why wasn't this failing on iOS7 ...
6 years, 6 months ago (2014-06-05 14:28:48 UTC) #3
sdefresne
lgtm
6 years, 6 months ago (2014-06-05 14:55:03 UTC) #4
pkl (ping after 24h if needed)
The CQ bit was checked by pkl@chromium.org
6 years, 6 months ago (2014-06-05 16:50:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkl@chromium.org/314123002/1
6 years, 6 months ago (2014-06-05 16:52:35 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 20:05:47 UTC) #7
Message was sent while issue was closed.
Change committed as 275227

Powered by Google App Engine
This is Rietveld 408576698