Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1358)

Issue 314113011: Moves common view_manager related aura files to mojo/aura (Closed)

Created:
6 years, 6 months ago by sky
Modified:
6 years, 6 months ago
CC:
chromium-reviews, ben+aura_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, sadrul, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Moves common view_manager related aura files to mojo/aura I'm going to use these files in other examples. I refactored the code slightly to update compositor via a delegate. This way the code can easily (hopefully) be used by view_manager_lib related code. I'm also making aura::Env extend base::SupportsUserData so that consumers can add arbitrary key/value pairs to Env. BUG=365012 TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275638

Patch Set 1 #

Patch Set 2 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+318 lines, -507 lines) Patch
M mojo/aura/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + mojo/aura/context_factory_mojo.h View 2 chunks +7 lines, -15 lines 0 comments Download
A + mojo/aura/context_factory_mojo.cc View 3 chunks +22 lines, -80 lines 0 comments Download
A + mojo/aura/window_tree_host_mojo.h View 1 2 chunks +22 lines, -7 lines 0 comments Download
A mojo/aura/window_tree_host_mojo.cc View 1 chunk +161 lines, -0 lines 0 comments Download
A mojo/aura/window_tree_host_mojo_delegate.h View 1 chunk +24 lines, -0 lines 0 comments Download
M mojo/examples/aura_demo/aura_demo.cc View 4 chunks +74 lines, -11 lines 0 comments Download
D mojo/examples/aura_demo/context_factory_view_manager.h View 1 chunk +0 lines, -48 lines 0 comments Download
D mojo/examples/aura_demo/context_factory_view_manager.cc View 1 chunk +0 lines, -194 lines 0 comments Download
D mojo/examples/aura_demo/window_tree_host_view_manager.h View 1 chunk +0 lines, -51 lines 0 comments Download
D mojo/examples/aura_demo/window_tree_host_view_manager.cc View 1 chunk +0 lines, -96 lines 0 comments Download
M mojo/mojo.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/mojo_examples.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/aura/env.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
sky
6 years, 6 months ago (2014-06-06 17:49:56 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 6 months ago (2014-06-06 17:53:27 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 6 months ago (2014-06-06 17:54:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/314113011/20001
6 years, 6 months ago (2014-06-06 17:55:52 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-07 05:59:50 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 08:17:49 UTC) #6
Message was sent while issue was closed.
Change committed as 275638

Powered by Google App Engine
This is Rietveld 408576698