Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: chrome/browser/omnibox/omnibox_log.h

Issue 314113009: Omnibox Metrics: Make |completed_length| field sane (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/ui/omnibox/omnibox_edit_model.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_OMNIBOX_OMNIBOX_LOG_H_ 5 #ifndef CHROME_BROWSER_OMNIBOX_OMNIBOX_LOG_H_
6 #define CHROME_BROWSER_OMNIBOX_OMNIBOX_LOG_H_ 6 #define CHROME_BROWSER_OMNIBOX_OMNIBOX_LOG_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include "base/strings/string16.h" 10 #include "base/strings/string16.h"
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 // in the omnibox. If at some point after modifying the text, the 66 // in the omnibox. If at some point after modifying the text, the
67 // user reverts the modifications (thus seeing the current web 67 // user reverts the modifications (thus seeing the current web
68 // page's URL again), then writes in the omnibox again, this time 68 // page's URL again), then writes in the omnibox again, this time
69 // delta should be computed starting from the second series of 69 // delta should be computed starting from the second series of
70 // modifications. If we somehow skipped the logic to record 70 // modifications. If we somehow skipped the logic to record
71 // the time the user began typing (this should only happen in 71 // the time the user began typing (this should only happen in
72 // unit tests), this elapsed time is set to -1 milliseconds. 72 // unit tests), this elapsed time is set to -1 milliseconds.
73 base::TimeDelta elapsed_time_since_user_first_modified_omnibox; 73 base::TimeDelta elapsed_time_since_user_first_modified_omnibox;
74 74
75 // The number of extra characters the user would have to manually type 75 // The number of extra characters the user would have to manually type
76 // if she/he were not given the opportunity to select this match. Set to 76 // if she/he were not given the opportunity to select this match. Only
77 // base::string16::npos if not available. 77 // set for matches that are allowed to be the default match (i.e., are
78 // inlineable). Set to base::string16::npos if the match is not allowed
79 // to be the default match.
78 size_t completed_length; 80 size_t completed_length;
79 81
80 // The amount of time since the last time the default (i.e., inline) 82 // The amount of time since the last time the default (i.e., inline)
81 // match changed. This will certainly be less than 83 // match changed. This will certainly be less than
82 // elapsed_time_since_user_first_modified_omnibox. Measuring this 84 // elapsed_time_since_user_first_modified_omnibox. Measuring this
83 // may be inappropriate in some cases (e.g., if editing is not in 85 // may be inappropriate in some cases (e.g., if editing is not in
84 // progress). In such cases, it's set to -1 milliseconds. 86 // progress). In such cases, it's set to -1 milliseconds.
85 base::TimeDelta elapsed_time_since_last_change_to_default_match; 87 base::TimeDelta elapsed_time_since_last_change_to_default_match;
86 88
87 // Result set. 89 // Result set.
88 const AutocompleteResult& result; 90 const AutocompleteResult& result;
89 91
90 // Diagnostic information from providers. See 92 // Diagnostic information from providers. See
91 // AutocompleteController::AddProvidersInfo() and 93 // AutocompleteController::AddProvidersInfo() and
92 // AutocompleteProvider::AddProviderInfo() above. 94 // AutocompleteProvider::AddProviderInfo() above.
93 ProvidersInfo providers_info; 95 ProvidersInfo providers_info;
94 }; 96 };
95 97
96 #endif // CHROME_BROWSER_OMNIBOX_OMNIBOX_LOG_H_ 98 #endif // CHROME_BROWSER_OMNIBOX_OMNIBOX_LOG_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/omnibox/omnibox_edit_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698