Oilpan: have MediaController weakly refer to its media elements.

Source/core/html/MediaController.h

Index: Source/core/html/MediaController.h
diff --git a/Source/core/html/MediaController.h b/Source/core/html/MediaController.h
index 29b7d9ac638ed25241d2748f675d07f836f46396..462dad711abdd694c7a32b572f9a46ccbaf5e502 100644
--- a/Source/core/html/MediaController.h
+++ b/Source/core/html/MediaController.h
@@ -29,9 +29,9 @@
 #include "bindings/v8/ScriptWrappable.h"
 #include "core/events/EventTarget.h"
 #include "core/html/HTMLMediaElement.h"
+#include "wtf/LinkedHashSet.h"
 #include "wtf/PassRefPtr.h"
 #include "wtf/RefCounted.h"
-#include "wtf/Vector.h"
 
 namespace WebCore {
 
@@ -86,6 +86,8 @@ public:
 
     void clearExecutionContext() { m_executionContext = 0; }
 
+    virtual void trace(Visitor*) OVERRIDE;
+
 private:
     MediaController(ExecutionContext*);
     void reportControllerState();
@@ -106,7 +108,8 @@ private:
 
     friend class HTMLMediaElement;
     friend class MediaControllerEventListener;
-    Vector<HTMLMediaElement*> m_mediaElements;
+    typedef WillBeHeapLinkedHashSet<RawPtrWillBeWeakMember<HTMLMediaElement> > MediaElementSequence;

[haraken, 2014/06/06 07:27:21]

I'm not sure if the order matters, so probably you can just use a HeapHashSet.
However, it would be better to keep the current behavior by using a
HeapLinkedHashSet.

[sof, 2014/06/06 07:32:45]

"they must be processed in the order that they were last associated with the
MediaController." says the spec, so I don't think that would be correct.

(http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element...
)

[haraken, 2014/06/06 07:33:25]

oh, thanks!

+    MediaElementSequence m_mediaElements;
     bool m_paused;
     double m_defaultPlaybackRate;
     double m_volume;