Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 314103003: [Android] Regression fix: dismiss popup menu on HW menu button press. (Closed)

Created:
6 years, 6 months ago by Kibeom Kim (inactive)
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android] Regression fix: dismiss popup menu on HW menu button press. BUG=366154 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275619

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java View 4 chunks +24 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Kibeom Kim (inactive)
6 years, 6 months ago (2014-06-06 01:50:54 UTC) #1
Ted C
lgtm
6 years, 6 months ago (2014-06-06 23:42:48 UTC) #2
Kibeom Kim (inactive)
The CQ bit was checked by kkimlabs@chromium.org
6 years, 6 months ago (2014-06-06 23:44:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/314103003/20001
6 years, 6 months ago (2014-06-06 23:45:51 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 05:06:00 UTC) #5
Message was sent while issue was closed. 
Change committed as 275619

Powered by Google App Engine
This is Rietveld 408576698