Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 314103002: Rename AwRenderFrameObserver to AwPrintRenderFrameObserver (Closed)

Created:
6 years, 6 months ago by hjd
Modified:
6 years, 6 months ago
Reviewers:
mkosiba (inactive)
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Rename AwRenderFrameObserver to AwPrintRenderFrameObserver The name AwRenderFrameObserver is insufficiently explicit since it deals only with printing. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275256

Patch Set 1 #

Patch Set 2 : Remove AW. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -87 lines) Patch
M android_webview/android_webview.gyp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/renderer/aw_content_renderer_client.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
D android_webview/renderer/aw_render_frame_observer.h View 1 chunk +0 lines, -31 lines 0 comments Download
D android_webview/renderer/aw_render_frame_observer.cc View 1 chunk +0 lines, -38 lines 0 comments Download
A + android_webview/renderer/print_render_frame_observer.h View 1 2 chunks +7 lines, -8 lines 0 comments Download
A + android_webview/renderer/print_render_frame_observer.cc View 1 3 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hjd
ptal
6 years, 6 months ago (2014-06-05 11:14:05 UTC) #1
mkosiba (inactive)
LGTM. nit:this class doesn't really need the Aw prefix. It's only needed if you're implementing ...
6 years, 6 months ago (2014-06-05 14:54:40 UTC) #2
hjd
The CQ bit was checked by hjd@chromium.org
6 years, 6 months ago (2014-06-05 16:40:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hjd@chromium.org/314103002/20001
6 years, 6 months ago (2014-06-05 16:47:02 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-05 20:51:54 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 22:06:02 UTC) #6
Message was sent while issue was closed.
Change committed as 275256

Powered by Google App Engine
This is Rietveld 408576698