make: Fixup variable names for actions and rules....

pylib/gyp/generator/make.py

 #!/usr/bin/python
 
 # Copyright (c) 2009 Google Inc. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Notes:
 #
 # This is all roughly based on the Makefile system used by the Linux
 # kernel, but is a non-recursive make -- we put the entire dependency
@@ skipping 479 matching lines @@
 
 
 def QuoteIfNecessary(string):
   """TODO: Should this ideally be replaced with one or more of the above
      functions?"""
   if '"' in string:
     string = '"' + string.replace('"', '\\"') + '"'
   return string
 
 
+def StringToMakefileVariable(string):
+  """Convert a string to a value that is acceptable as a make variable name."""
+  # TODO: replace other metacharacters that we encounter.
+  return string.replace(' ', '_')
+
+
 srcdir_prefix = ''
 def Sourceify(path):
   """Convert a path to its source directory form."""
   if '$(' in path:
     return path
   if os.path.isabs(path):
     return path
   return srcdir_prefix + path
 
 
@@ skipping 139 matching lines @@
     """Write Makefile code for any 'actions' from the gyp input.
 
     extra_sources: a list that will be filled in with newly generated source
                    files, if any
     extra_outputs: a list that will be filled in with any outputs of these
                    actions (used to make other pieces dependent on these
                    actions)
     part_of_all: flag indicating this target is part of 'all'
     """
     for action in actions:
-      name = self.target + '_' + action['action_name']
+      name = self.target + '_' + StringToMakefileVariable(action['action_name'])
       self.WriteLn('### Rules for action "%s":' % action['action_name'])
       inputs = action['inputs']
       outputs = action['outputs']
 
       # Build up a list of outputs.
       # Collect the output dirs we'll need.
       dirs = set()
       for out in outputs:
         dir = os.path.split(out)[0]
         if dir:
@@ skipping 48 matching lines @@
   def WriteRules(self, rules, extra_sources, extra_outputs, part_of_all):
     """Write Makefile code for any 'rules' from the gyp input.
 
     extra_sources: a list that will be filled in with newly generated source
                    files, if any
     extra_outputs: a list that will be filled in with any outputs of these
                    rules (used to make other pieces dependent on these rules)
     part_of_all: flag indicating this target is part of 'all'
     """
     for rule in rules:
-      name = self.target + '_' + rule['rule_name']
+      name = self.target + '_' + StringToMakefileVariable(rule['rule_name'])
       count = 0
       self.WriteLn('### Generated for rule %s:' % name)
 
       all_outputs = []
 
       for rule_source in rule['rule_sources']:
         dirs = set()
         rule_source_basename = os.path.basename(rule_source)
         (rule_source_root, rule_source_ext) = \
             os.path.splitext(rule_source_basename)
@@ skipping 582 matching lines @@
         makefile_name,
         ' '.join(map(Sourceify, build_files)),
         gyp.common.EncodePOSIXShellList(
             [gyp_binary, '-fmake'] +
             gyp.RegenerateFlags(options) +
             build_files_args)))
 
   root_makefile.write(SHARED_FOOTER)
 
   root_makefile.close()