Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2594)

Unified Diff: Source/platform/network/HTTPParsersTest.cpp

Issue 314083002: parseHTTPHeaders should return the number of consumed bytes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@async-initializer
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/network/HTTPParsersTest.cpp
diff --git a/Source/platform/network/HTTPParsersTest.cpp b/Source/platform/network/HTTPParsersTest.cpp
index ac47eb35bf8f333cbceb93a811c0a049b5ec7464..1bcef8497bf0116d22333032f9d4b7cfb0b5e81a 100644
--- a/Source/platform/network/HTTPParsersTest.cpp
+++ b/Source/platform/network/HTTPParsersTest.cpp
@@ -108,7 +108,7 @@ TEST(HTTPParsersTest, parseHTTPHeaderSimple)
{
String failureReason;
AtomicString name, value;
- EXPECT_EQ(11u, parseHTTPHeader("foo: bar\r\notherdata", failureReason, name, value));
+ EXPECT_EQ(12u, parseHTTPHeader("foo: bar\r\notherdata", failureReason, name, value));
EXPECT_TRUE(failureReason.isEmpty());
EXPECT_EQ("foo", name.string());
EXPECT_EQ("bar", value.string());
@@ -126,7 +126,7 @@ TEST(HTTPParsersTest, parseHTTPHeaderEmptyValue)
{
String failureReason;
AtomicString name, value;
- EXPECT_EQ(6u, parseHTTPHeader("foo: \r\notherdata", failureReason, name, value));
+ EXPECT_EQ(7u, parseHTTPHeader("foo: \r\notherdata", failureReason, name, value));
EXPECT_TRUE(failureReason.isEmpty());
EXPECT_EQ("foo", name.string());
EXPECT_TRUE(value.isEmpty());
@@ -212,12 +212,12 @@ TEST(HTTPParsersTest, parseHTTPHeaderTwoLines)
String failureReason;
AtomicString name, value;
- EXPECT_EQ(9u, parseHTTPHeader(data, failureReason, name, value));
+ EXPECT_EQ(10u, parseHTTPHeader(data, failureReason, name, value));
EXPECT_TRUE(failureReason.isEmpty());
EXPECT_EQ("foo", name.string());
EXPECT_EQ("bar", value.string());
- EXPECT_EQ(11u, parseHTTPHeader(data + 10, failureReason, name, value));
+ EXPECT_EQ(12u, parseHTTPHeader(data + 10, failureReason, name, value));
EXPECT_TRUE(failureReason.isEmpty());
EXPECT_EQ("hoge", name.string());
EXPECT_EQ("fuga", value.string());

Powered by Google App Engine
This is Rietveld 408576698