Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 314083002: parseHTTPHeaders should return the number of consumed bytes. (Closed)

Created:
6 years, 6 months ago by yhirano
Modified:
6 years, 6 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@async-initializer
Visibility:
Public.

Description

parseHTTPHeaders should return the number of consumed bytes. Currently parseHTTPHeaders returns (the number of consumed bytes - x) where - x = 0 if it consumes an empty line - x = 1 otherwise This CL make parseHTTPHeaders always return the number of consumed bytes. BUG=NONE R=tyoshino Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175630

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M Source/modules/websockets/WebSocketHandshake.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/network/HTTPParsers.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/platform/network/HTTPParsersTest.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/network/HTTPRequest.cpp View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 18 (0 generated)
yhirano
6 years, 6 months ago (2014-06-05 08:16:54 UTC) #1
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/314083002/diff/1/Source/platform/network/HTTPRequest.cpp File Source/platform/network/HTTPRequest.cpp (right): https://codereview.chromium.org/314083002/diff/1/Source/platform/network/HTTPRequest.cpp#newcode90 Source/platform/network/HTTPRequest.cpp:90: break; we never reached here before your last fix?
6 years, 6 months ago (2014-06-05 08:24:15 UTC) #2
yhirano
https://codereview.chromium.org/314083002/diff/1/Source/platform/network/HTTPRequest.cpp File Source/platform/network/HTTPRequest.cpp (right): https://codereview.chromium.org/314083002/diff/1/Source/platform/network/HTTPRequest.cpp#newcode90 Source/platform/network/HTTPRequest.cpp:90: break; On 2014/06/05 08:24:15, tyoshino wrote: > we never ...
6 years, 6 months ago (2014-06-05 08:33:19 UTC) #3
tyoshino (SeeGerritForStatus)
lgtm
6 years, 6 months ago (2014-06-05 08:37:33 UTC) #4
yhirano
+tkent for OWNER review.
6 years, 6 months ago (2014-06-05 08:38:15 UTC) #5
tkent
lgtm
6 years, 6 months ago (2014-06-05 23:03:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/314083002/1
6 years, 6 months ago (2014-06-05 23:04:12 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-06 00:22:21 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 00:22:43 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/14564)
6 years, 6 months ago (2014-06-06 00:22:43 UTC) #10
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-06-06 00:28:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/314083002/1
6 years, 6 months ago (2014-06-06 00:28:58 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-06 01:29:43 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 01:32:27 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/11233)
6 years, 6 months ago (2014-06-06 01:32:28 UTC) #15
yhirano
The CQ bit was checked by yhirano@chromium.org
6 years, 6 months ago (2014-06-06 01:34:15 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/314083002/1
6 years, 6 months ago (2014-06-06 01:35:00 UTC) #17
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 03:27:51 UTC) #18
Message was sent while issue was closed.
Change committed as 175630

Powered by Google App Engine
This is Rietveld 408576698