Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 314073002: Address a few TODOs in the gn config (Closed)

Created:
6 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Address a few TODOs in the gn config - add direct dependant settings - only compile mksnapshot on the host toolset BUG=none LOG=n R=machenbach@chromium.org, brettw@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21689

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -8 lines) Patch
M BUILD.gn View 5 chunks +23 lines, -8 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 6 months ago (2014-06-05 07:16:10 UTC) #1
Michael Achenbach
lgtm (rubberstamp) - have too little understanding for a real lgtm https://codereview.chromium.org/314073002/diff/1/BUILD.gn File BUILD.gn (right): ...
6 years, 6 months ago (2014-06-05 08:24:34 UTC) #2
jochen (gone - plz use gerrit)
6 years, 6 months ago (2014-06-05 08:45:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21689 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698