Cleanup v8 usage in bindings

Cleanup v8 usage in bindings

Followup to:
Cleanup v8 usage in modules
https://codereview.chromium.org/319653002/

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175626

[haraken, 2014-06-05 07:06:48]

LGTM

[Nils Barth (inactive), 2014-06-05 07:19:44]

The CQ bit was checked by nbarth@chromium.org

[commit-bot: I haz the power, 2014-06-05 07:20:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nbarth@chromium.org/314063002/1

[commit-bot: I haz the power, 2014-06-05 08:30:35]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10384)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/10743)

[commit-bot: I haz the power, 2014-06-05 08:59:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-05 08:59:16]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10396)

[Nils Barth (inactive), 2014-06-06 01:14:04]

The CQ bit was checked by nbarth@chromium.org

[commit-bot: I haz the power, 2014-06-06 01:15:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nbarth@chromium.org/314063002/1

[commit-bot: I haz the power, 2014-06-06 02:21:48]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/10900)

[commit-bot: I haz the power, 2014-06-06 03:20:04]

Change committed as 175626

[tkent, 2014-06-06 08:19:23]

IMO, we should include v8 headers like:

    #include "v8/include/v8.h"

- We'd like to reduce includes without directory names.
- It's consistent with Chromium
- We can add DEPS rules to allow/disallow v8 includes.

[Nils Barth (inactive), 2014-06-06 09:27:53]

On 2014/06/06 08:19:23, tkent wrote:
> IMO, we should include v8 headers like:
> 
>     #include "v8/include/v8.h"
> 
> - We'd like to reduce includes without directory names.
> - It's consistent with Chromium
> - We can add DEPS rules to allow/disallow v8 includes.

That sounds eminently sensible.
haraken, abarth, etc.: thoughts?

[haraken, 2014-06-06 09:35:34]

On 2014/06/06 09:27:53, Nils Barth wrote:
> On 2014/06/06 08:19:23, tkent wrote:
> > IMO, we should include v8 headers like:
> > 
> >     #include "v8/include/v8.h"
> > 
> > - We'd like to reduce includes without directory names.
> > - It's consistent with Chromium
> > - We can add DEPS rules to allow/disallow v8 includes.
> 
> That sounds eminently sensible.
> haraken, abarth, etc.: thoughts?

Sounds good to me.

[Nils Barth (inactive), 2014-06-06 11:15:25]

On 2014/06/06 09:35:34, haraken wrote:
> Sounds good to me.

Added to bug:
Issue 381046: core and modules shouldn't call V8 directly	
https://code.google.com/p/chromium/issues/detail?id=381046

...in comment:
https://code.google.com/p/chromium/issues/detail?id=381046#c1