Issue 314043002: [WebSocket] Add tests for permessage deflate split frames.

Issue 314043002: [WebSocket] Add tests for permessage deflate split frames. (Closed)

Created:
6 years, 6 months ago by yhirano

Modified:
6 years, 6 months ago

Reviewers:
tyoshino (SeeGerritForStatus)

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

[WebSocket] Add tests for permessage deflate split frames. Upgrade pywebsocket to r804. BUG=NONE R=tyoshino Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175544

Patch Set 5 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+282 lines, -170 lines)			Patch
A	LayoutTests/http/tests/websocket/permessage-deflate-split-frames.html	View	1 2 3 4	1 chunk	+31 lines, -0 lines	0 comments	Download
A +	LayoutTests/http/tests/websocket/permessage-deflate-split-frames-expected.txt	View	1 2 3 4	1 chunk	+3 lines, -1 line	0 comments	Download
A	LayoutTests/http/tests/websocket/permessage-deflate-split-frames_wsh.py	View	1 2 3 4	1 chunk	+43 lines, -0 lines	0 comments	Download
M	Source/modules/websockets/WebSocketPerMessageDeflateTest.cpp	View		1 chunk	+25 lines, -0 lines	0 comments	Download
M	Tools/Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py	View		7 chunks	+7 lines, -11 lines	0 comments	Download
M	Tools/Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py	View		4 chunks	+4 lines, -32 lines	0 comments	Download
M	Tools/Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py	View		5 chunks	+2 lines, -17 lines	0 comments	Download
M	Tools/Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py	View		7 chunks	+46 lines, -104 lines	0 comments	Download
M	Tools/Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py	View		2 chunks	+11 lines, -5 lines	0 comments	Download
A	Tools/Scripts/webkitpy/thirdparty/mod_pywebsocket/xhr_benchmark_handler.py	View		1 chunk	+110 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

tyoshino (SeeGerritForStatus)

lgtm https://codereview.chromium.org/314043002/diff/60001/LayoutTests/http/tests/websocket/permessage-deflate-split-frames.html File LayoutTests/http/tests/websocket/permessage-deflate-split-frames.html (right): https://codereview.chromium.org/314043002/diff/60001/LayoutTests/http/tests/websocket/permessage-deflate-split-frames.html#newcode25 LayoutTests/http/tests/websocket/permessage-deflate-split-frames.html:25: debug("onclose"); use ' https://codereview.chromium.org/314043002/diff/60001/LayoutTests/http/tests/websocket/permessage-deflate-split-frames_wsh.py File LayoutTests/http/tests/websocket/permessage-deflate-split-frames_wsh.py (right): https://codereview.chromium.org/314043002/diff/60001/LayoutTests/http/tests/websocket/permessage-deflate-split-frames_wsh.py#newcode8 ...

6 years, 6 months ago (2014-06-05 05:49:44 UTC) #2

yhirano

https://codereview.chromium.org/314043002/diff/60001/LayoutTests/http/tests/websocket/permessage-deflate-split-frames.html File LayoutTests/http/tests/websocket/permessage-deflate-split-frames.html (right): https://codereview.chromium.org/314043002/diff/60001/LayoutTests/http/tests/websocket/permessage-deflate-split-frames.html#newcode25 LayoutTests/http/tests/websocket/permessage-deflate-split-frames.html:25: debug("onclose"); On 2014/06/05 05:49:44, tyoshino wrote: > use ' ...

6 years, 6 months ago (2014-06-05 05:57:20 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/314043002/80001

6 years, 6 months ago (2014-06-05 05:58:07 UTC) #5

Message was sent while issue was closed.

Change committed as 175544

Expand Messages | Collapse Messages