Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 314033002: Files.app: Flip the flag and enable MTP support by default. (Closed)

Created:
6 years, 6 months ago by kinaba
Modified:
6 years, 6 months ago
Reviewers:
hirono, joshwoodward1
CC:
chromium-reviews, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Flip the flag and enable MTP support by default. The --enable-filemanager-mtp is now on by default. It can still be disabled by --enable-filemanager-mtp=false, or choosing "disabled" in about:flags. BUG=266939 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275375

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M chrome/browser/about_flags.cc View 1 2 chunks +11 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
kinaba
Remaining task is Bug 367027 (= opening html and pdf directly from MTP volume) but ...
6 years, 6 months ago (2014-06-05 05:38:20 UTC) #1
hirono
On 2014/06/05 05:38:20, kinaba wrote: > Remaining task is Bug 367027 (= opening html and ...
6 years, 6 months ago (2014-06-05 11:00:46 UTC) #2
joshwoodward1
Yes, please enable the flag. We'll get HTML and PDF in M-38. Thanks!
6 years, 6 months ago (2014-06-05 16:54:15 UTC) #3
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 6 months ago (2014-06-05 22:47:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/314033002/1
6 years, 6 months ago (2014-06-05 22:48:25 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-05 23:36:05 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 23:40:24 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/11309) chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/72025) linux_chromium_gn_rel ...
6 years, 6 months ago (2014-06-05 23:40:25 UTC) #8
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 6 months ago (2014-06-06 00:37:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/314033002/20001
6 years, 6 months ago (2014-06-06 00:39:50 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 10:26:23 UTC) #11
Message was sent while issue was closed.
Change committed as 275375

Powered by Google App Engine
This is Rietveld 408576698