base/files/file_unittest.cc - Issue 314023002: Require FLAG_WRITE when FLAG_CREATE_ALWAYS is specified

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/files/file_unittest.cc

Issue 314023002: Require FLAG_WRITE when FLAG_CREATE_ALWAYS is specified (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix PlatformFile.CreatePlatformFile test Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/files/file_unittest.cc

diff --git a/base/files/file_unittest.cc b/base/files/file_unittest.cc

index 468b2a83bd1f19b9513261dda893b0cc99bc0904..cba043c332f090dc38393203eccba037030b8950 100644

--- a/base/files/file_unittest.cc

+++ b/base/files/file_unittest.cc

@@ -78,7 +78,7 @@ TEST(FileTest, Create) {

{

// Create or overwrite a file.

File file(file_path,

- base::File::FLAG_CREATE_ALWAYS | base::File::FLAG_READ);

+ base::File::FLAG_CREATE_ALWAYS | base::File::FLAG_WRITE);

EXPECT_TRUE(file.IsValid());

EXPECT_TRUE(file.created());

EXPECT_EQ(base::File::FILE_OK, file.error_details());