[AiS] Add prefetching for Answers images.

chrome/browser/autocomplete/base_search_provider.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autocomplete/base_search_provider.h"
 
 #include "base/i18n/case_conversion.h"
 #include "base/i18n/icu_string_conversions.h"
 #include "base/json/json_string_value_serializer.h"
 #include "base/json/json_writer.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
+#include "chrome/browser/autocomplete/answers_image_service.h"
+#include "chrome/browser/autocomplete/answers_image_service_factory.h"
 #include "chrome/browser/autocomplete/autocomplete_provider_listener.h"
 #include "chrome/browser/autocomplete/url_prefix.h"
 #include "chrome/browser/history/history_service.h"
 #include "chrome/browser/history/history_service_factory.h"
 #include "chrome/browser/omnibox/omnibox_field_trial.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/search/instant_service.h"
 #include "chrome/browser/search/instant_service_factory.h"
 #include "chrome/browser/search/search.h"
 #include "chrome/browser/search_engines/template_url.h"
@@ skipping 881 matching lines @@
           suggestion_detail->GetString("mp", &match_contents_prefix);
           // Error correction for bad data from server.
           if (match_contents.empty())
             match_contents = suggestion;
           suggestion_detail->GetString("a", &annotation);
           suggestion_detail->GetString("q", &suggest_query_params);
 
           // Extract Answers, if provided.
           const base::DictionaryValue* answer_json = NULL;
           if (suggestion_detail->GetDictionary("ansa", &answer_json)) {
+            PrefetchAnswersImages(answer_json);
             std::string contents;
             base::JSONWriter::Write(answer_json, &contents);
             answer_contents = base::UTF8ToUTF16(contents);
             suggestion_detail->GetString("ansb", &answer_type);
           }
         }
       }
 
       bool should_prefetch = static_cast<int>(index) == prefetch_index;
       // TODO(kochi): Improve calculator suggestion presentation.
       results->suggest_results.push_back(SuggestResult(
           base::CollapseWhitespace(suggestion, false), match_type,
           base::CollapseWhitespace(match_contents, false),
           match_contents_prefix, annotation, answer_contents, answer_type,
           suggest_query_params, deletion_url, is_keyword_result, relevance,
           relevances != NULL, should_prefetch, trimmed_input));
     }
   }
   SortResults(is_keyword_result, relevances, results);
   return true;
 }
 
+void BaseSearchProvider::PrefetchAnswersImages(
+    const base::DictionaryValue* answer_json) {
+  DCHECK(answer_json);
+  const base::ListValue* lines = NULL;
+  answer_json->GetList("l", &lines);
+  if (!lines || lines->GetSize() == 0)
+    return;
+
+  // TODO(groby): Do we want prefetch in incognito?

[Peter Kasting, 2014/06/05 23:42:47]

We don't currently send suggest requests in incognito, so I wouldn't think you
could reach here then.

[groby-ooo-7-16, 2014/06/14 00:22:08]

Done.

+  AnswersImageService* image_service =
+      AnswersImageServiceFactory::GetForBrowserContext(profile_);
+  DCHECK(image_service);
+
+  for (size_t line = 0; line < lines->GetSize(); ++line) {
+    const base::DictionaryValue* imageLine = NULL;
+    lines->GetDictionary(line, &imageLine);
+    if (!imageLine)
+      continue;
+    const base::DictionaryValue* imageData = NULL;
+    imageLine->GetDictionary("i", &imageData);
+    if (!imageData)
+      continue;
+    std::string imageUrl;
+    imageData->GetString("d", &imageUrl);
+
+    // Not having an URL is technically a malformed reply, but crashing seems
+    // overly harsh as response.

[Peter Kasting, 2014/06/05 23:42:47]

This comment doesn't seem necessary -- clearly we have to validate any
server-provided data and never crash, so it doesn't seem important to try and
distinguish this sort of malformation from the cases we handle above.

[groby-ooo-7-16, 2014/06/14 00:22:08]

Removed.

+    if (imageUrl.empty())
+      continue;
+    LOG(ERROR) << "Prefetching image for " << imageUrl;

[Peter Kasting, 2014/06/05 23:42:47]

I don't think you should check this line in.

[groby-ooo-7-16, 2014/06/14 00:22:08]

Done.

+    image_service->Prefetch(GURL(imageUrl));

[Peter Kasting, 2014/06/05 23:42:47]

What if GURL(imageUrl) is invalid?  This can happen for more than just an empty
|imageUrl|.  Either Prefetch() needs to validate its input -- in which case you
don't need the empty() check above, since that will handle that case -- or you
need to validity-check the GURL here (and probably DCHECK that it's valid in
Prefetch()), which will again obviate the need for the empty() check above.

[groby-ooo-7-16, 2014/06/14 00:22:08]

Done.

+  }
+}
+
 void BaseSearchProvider::SortResults(bool is_keyword,
                                      const base::ListValue* relevances,
                                      Results* results) {
 }
 
 bool BaseSearchProvider::StoreSuggestionResponse(
     const std::string& json_data,
     const base::Value& parsed_data) {
   return false;
 }
@@ skipping 18 matching lines @@
 }
 
 void BaseSearchProvider::OnDeletionComplete(
     bool success, SuggestionDeletionHandler* handler) {
   RecordDeletionResult(success);
   SuggestionDeletionHandlers::iterator it = std::find(
       deletion_handlers_.begin(), deletion_handlers_.end(), handler);
   DCHECK(it != deletion_handlers_.end());
   deletion_handlers_.erase(it);
 }