New PyAuto tests for importing browser data. BUG=52009

New PyAuto tests for importing browser data. BUG=52009
Tests for importing browser data from Firefox, Safari, and IE.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57619

[Alyssa, 2010-08-19 21:40:07]

Import tests for IE will be added later.

[Nirnimesh, 2010-08-20 01:55:57]

preliminary comments.

http://codereview.chromium.org/3140011/diff/1003/16004
File chrome/test/functional/imports.py (right):

http://codereview.chromium.org/3140011/diff/1003/16004#newcode21
chrome/test/functional/imports.py:21: """ Import settings from other browsers.
Remove space after """

http://codereview.chromium.org/3140011/diff/18001/19004#newcode24
chrome/test/functional/imports.py:24: via preferences for all major browsers and
operating systems.
s/all major/different/

http://codereview.chromium.org/3140011/diff/18001/19004#newcode37
chrome/test/functional/imports.py:37: _temp_dir_path = ' '
this is unused

http://codereview.chromium.org/3140011/diff/18001/19004#newcode38
chrome/test/functional/imports.py:38: _profiles_extension = ''
this too

http://codereview.chromium.org/3140011/diff/18001/19004#newcode40
chrome/test/functional/imports.py:40: if pyauto.PyUITest.IsMac():
Please move all this code inside setUp()

http://codereview.chromium.org/3140011/diff/18001/19004#newcode42
chrome/test/functional/imports.py:42:
os.path.expanduser('~/Library'),'Application Support','Firefox')
It's rude to use ~
Use os.environ['HOME'] instead. replace elsewhere too

http://codereview.chromium.org/3140011/diff/18001/19004#newcode49
chrome/test/functional/imports.py:49: os.getenv('USERPROFILE'), 'Application
Data', 'Mozilla', 'Firefox')
fix this for different windows variants.

On my win7 machine this is:
%appdata%\Mozilla\Firefox\Profiles

http://support.mozilla.com/en-us/kb/Profiles has the complete list for all OSes

http://codereview.chromium.org/3140011/diff/18001/19004#newcode52
chrome/test/functional/imports.py:52: else:  # Linux (includes ChromeOS)
why chromeos? import from other browsers usecase is invalid on chromeos

http://codereview.chromium.org/3140011/diff/18001/19004#newcode58
chrome/test/functional/imports.py:58: _history_items = set(['Google', 'Google
News', u'Google \ub3c4\uc11c'])
add a comment --
"Expected items"

http://codereview.chromium.org/3140011/diff/18001/19004#newcode63
chrome/test/functional/imports.py:63:
self._SwapOriginalProfile(self._firefox_profiles_path,
This will get called for each test, even the safari ones. We should move these
inside the respective test.

http://codereview.chromium.org/3140011/diff/18001/19004#newcode66
chrome/test/functional/imports.py:66:
self._SwapOriginalProfile(self._safari_profiles_path, os.path.join(
this too

http://codereview.chromium.org/3140011/diff/18001/19004#newcode99
chrome/test/functional/imports.py:99: except Exception, e:
Remove the except block. Doesn't work with py2.4

http://codereview.chromium.org/3140011/diff/18001/19004#newcode105
chrome/test/functional/imports.py:105: """Backs up the original firefox profile
and swaps in the test one."""
fix comment. this is not just for firefox

http://codereview.chromium.org/3140011/diff/18001/19004#newcode107
chrome/test/functional/imports.py:107: backup_dir = profile_dir + '_backup'
what is Profiles_backup already exists?
Use tempfile.mkdtemp

http://codereview.chromium.org/3140011/diff/18001/19004#newcode110
chrome/test/functional/imports.py:110: items =
glob.glob(os.path.join(profile_dir, '*'))
use os.listdir()

http://codereview.chromium.org/3140011/diff/18001/19004#newcode140
chrome/test/functional/imports.py:140: node = bookmarks.BookmarkBar() if
bookmark_bar else bookmarks.Other()
py2.4 doesn't understand this construct

[Nirnimesh, 2010-08-20 01:56:48]

Please add a README in the chrome/test/data/import folder explaining the
contents of the different profiles.

[Alyssa, 2010-08-20 17:57:01]

Added the README, verified that all tests pass on Mac/Linux. Let me know when I
can come try on your Windows machine.

http://codereview.chromium.org/3140011/diff/18001/19004
File chrome/test/functional/imports.py (right):

http://codereview.chromium.org/3140011/diff/18001/19004#newcode24
chrome/test/functional/imports.py:24: via preferences for all major browsers and
operating systems.
On 2010/08/20 01:55:58, Nirnimesh wrote:
> s/all major/different/

Done.

http://codereview.chromium.org/3140011/diff/18001/19004#newcode37
chrome/test/functional/imports.py:37: _temp_dir_path = ' '
On 2010/08/20 01:55:58, Nirnimesh wrote:
> this is unused

Done.

http://codereview.chromium.org/3140011/diff/18001/19004#newcode38
chrome/test/functional/imports.py:38: _profiles_extension = ''
On 2010/08/20 01:55:58, Nirnimesh wrote:
> this too

Done.

http://codereview.chromium.org/3140011/diff/18001/19004#newcode40
chrome/test/functional/imports.py:40: if pyauto.PyUITest.IsMac():
On 2010/08/20 01:55:58, Nirnimesh wrote:
> Please move all this code inside setUp()

Done.

http://codereview.chromium.org/3140011/diff/18001/19004#newcode42
chrome/test/functional/imports.py:42:
os.path.expanduser('~/Library'),'Application Support','Firefox')
On 2010/08/20 01:55:58, Nirnimesh wrote:
> It's rude to use ~
> Use os.environ['HOME'] instead. replace elsewhere too

Well I don't want to be rude :). Thanks for the info.

http://codereview.chromium.org/3140011/diff/18001/19004#newcode49
chrome/test/functional/imports.py:49: os.getenv('USERPROFILE'), 'Application
Data', 'Mozilla', 'Firefox')
On 2010/08/20 01:55:58, Nirnimesh wrote:
> fix this for different windows variants.
> 
> On my win7 machine this is:
> %appdata%\Mozilla\Firefox\Profiles
> 
> http://support.mozilla.com/en-us/kb/Profiles has the complete list for all
OSes

Done.

http://codereview.chromium.org/3140011/diff/18001/19004#newcode52
chrome/test/functional/imports.py:52: else:  # Linux (includes ChromeOS)
On 2010/08/20 01:55:58, Nirnimesh wrote:
> why chromeos? import from other browsers usecase is invalid on chromeos
Ha, good point.

http://codereview.chromium.org/3140011/diff/18001/19004#newcode58
chrome/test/functional/imports.py:58: _history_items = set(['Google', 'Google
News', u'Google \ub3c4\uc11c'])
On 2010/08/20 01:55:58, Nirnimesh wrote:
> add a comment --
> "Expected items"

Done.

http://codereview.chromium.org/3140011/diff/18001/19004#newcode63
chrome/test/functional/imports.py:63:
self._SwapOriginalProfile(self._firefox_profiles_path,
On 2010/08/20 01:55:58, Nirnimesh wrote:
> This will get called for each test, even the safari ones. We should move these
> inside the respective test.

Done.

http://codereview.chromium.org/3140011/diff/18001/19004#newcode66
chrome/test/functional/imports.py:66:
self._SwapOriginalProfile(self._safari_profiles_path, os.path.join(
On 2010/08/20 01:55:58, Nirnimesh wrote:
> this too

Done.

http://codereview.chromium.org/3140011/diff/18001/19004#newcode99
chrome/test/functional/imports.py:99: except Exception, e:
On 2010/08/20 01:55:58, Nirnimesh wrote:
> Remove the except block. Doesn't work with py2.4

Done.

http://codereview.chromium.org/3140011/diff/18001/19004#newcode105
chrome/test/functional/imports.py:105: """Backs up the original firefox profile
and swaps in the test one."""
On 2010/08/20 01:55:58, Nirnimesh wrote:
> fix comment. this is not just for firefox

Done.

http://codereview.chromium.org/3140011/diff/18001/19004#newcode107
chrome/test/functional/imports.py:107: backup_dir = profile_dir + '_backup'
On 2010/08/20 01:55:58, Nirnimesh wrote:
> what is Profiles_backup already exists?
> Use tempfile.mkdtemp

Done.

http://codereview.chromium.org/3140011/diff/18001/19004#newcode110
chrome/test/functional/imports.py:110: items =
glob.glob(os.path.join(profile_dir, '*'))
On 2010/08/20 01:55:58, Nirnimesh wrote:
> use os.listdir()

Done.

http://codereview.chromium.org/3140011/diff/18001/19004#newcode140
chrome/test/functional/imports.py:140: node = bookmarks.BookmarkBar() if
bookmark_bar else bookmarks.Other()
On 2010/08/20 01:55:58, Nirnimesh wrote:
> py2.4 doesn't understand this construct

Done.

[Alyssa, 2010-08-23 21:10:45]

I updated the test to use the ExistingPathReplacer helper class. The changes
have been uploaded in the latest patch.

[Nirnimesh, 2010-08-26 00:34:05]

http://codereview.chromium.org/3140011/diff/24001/25001
File chrome/test/data/import/README (right):

http://codereview.chromium.org/3140011/diff/24001/25001#newcode1
chrome/test/data/import/README:1: New profiles for import settings go in this
folder. They are used by the tests
s/New//

http://codereview.chromium.org/3140011/diff/24001/25005
File chrome/test/functional/imports.py (right):

http://codereview.chromium.org/3140011/diff/24001/25005#newcode90
chrome/test/functional/imports.py:90: def _SwapProfiles(self, firefox=False,
safari=False):
There isn't any common code in this function.
Why not break into _SwapFirefoxProfile and _SwapSafariProfile?

http://codereview.chromium.org/3140011/diff/27001/28001
File chrome/test/data/import/README (right):

http://codereview.chromium.org/3140011/diff/27001/28001#newcode22
chrome/test/data/import/README:22: TODO(alyssad): In the future, add search
engines.
The new First Run UI doesn't import search engines, since it asks the user for
the search engine to use. Remove this line.

http://codereview.chromium.org/3140011/diff/27001/28005
File chrome/test/functional/imports.py (right):

http://codereview.chromium.org/3140011/diff/27001/28005#newcode23
chrome/test/functional/imports.py:23: """ Import settings from other browsers.
Remove space after """

http://codereview.chromium.org/3140011/diff/27001/28005#newcode65
chrome/test/functional/imports.py:65: """Unzip |profile_zip| into directory
|dir|."""
add a comment mentioning that it creates |dir| if it doesn't exist.

http://codereview.chromium.org/3140011/diff/27001/28005#newcode96
chrome/test/functional/imports.py:96: # TODO(alyssad): Add ie when the profile
and tests are ready.
s/ie/IE/

http://codereview.chromium.org/3140011/diff/27001/28005#newcode123
chrome/test/functional/imports.py:123: shutil.rmtree(profile_dir)
you don't need this and next line.
ExistingPathReplacer creates an empty dir for you, while backing up (if
required)

http://codereview.chromium.org/3140011/diff/27001/28005#newcode132
chrome/test/functional/imports.py:132: del self._replacer
Add a comment.
del self._replacer  # Reinstates original profile dir (if any).

http://codereview.chromium.org/3140011/diff/27001/28005#newcode166
chrome/test/functional/imports.py:166: """Check if the list of history items are
in the history.
s/Check if the/Verifies that the given/

http://codereview.chromium.org/3140011/diff/27001/28005#newcode173
chrome/test/functional/imports.py:173: confirmed_history_titles = set()
why do we need the set here?
we can simple assert that the title exists in history in linfe 176

for title in history_titles:
  self.assertTrue([x for x in history if x['title'] == title])

http://codereview.chromium.org/3140011/diff/27001/28005#newcode182
chrome/test/functional/imports.py:182: # Password imports do not work on Mac.
See crbug.com/52124.
s/password imports/password import automation/

http://codereview.chromium.org/3140011/diff/27001/28005#newcode186
chrome/test/functional/imports.py:186: confirmed_usernames = set()
this too can be shortened like above

http://codereview.chromium.org/3140011/diff/27001/28005#newcode199
chrome/test/functional/imports.py:199: self._CheckForBookmarks(set(['Google
News']), True)
does it have to be a set? a list won't do?

http://codereview.chromium.org/3140011/diff/27001/28005#newcode200
chrome/test/functional/imports.py:200: self._CheckForBookmarks(set(['Google',
u'Google \ub3c4\uc11c']), False)
use a member variable like that for history

http://codereview.chromium.org/3140011/diff/27001/28005#newcode211
chrome/test/functional/imports.py:211: def testFirefoxPreferences(self):
this sounds like it's a test for firefox preferences.
rename to testFirefoxImportFromPrefs

http://codereview.chromium.org/3140011/diff/27001/28005#newcode232
chrome/test/functional/imports.py:232: def testImportFromFirefoxAndSafari(self):
Please break it out into a separate test for FF and Safari

http://codereview.chromium.org/3140011/diff/27001/28005#newcode261
chrome/test/functional/imports.py:261: set(['Google', 'Google News', u'Google
\ub3c4\uc11c'])))
use this data from a member variable defined in __init__

http://codereview.chromium.org/3140011/diff/27001/28005#newcode266
chrome/test/functional/imports.py:266: def testSafariPreferences(self):
rename: testSafariImportFromPrefs

http://codereview.chromium.org/3140011/diff/27001/28005#newcode303
chrome/test/functional/imports.py:303: set(['Google', 'Google News', u'Google
\ub3c4\uc11c'])))
use this data from a preset member var

[Alyssa, 2010-08-26 01:17:14]

http://codereview.chromium.org/3140011/diff/24001/25001
File chrome/test/data/import/README (right):

http://codereview.chromium.org/3140011/diff/24001/25001#newcode1
chrome/test/data/import/README:1: New profiles for import settings go in this
folder. They are used by the tests
On 2010/08/26 00:34:05, Nirnimesh wrote:
> s/New//

Done.

http://codereview.chromium.org/3140011/diff/24001/25005
File chrome/test/functional/imports.py (right):

http://codereview.chromium.org/3140011/diff/24001/25005#newcode90
chrome/test/functional/imports.py:90: def _SwapProfiles(self, firefox=False,
safari=False):
On 2010/08/26 00:34:05, Nirnimesh wrote:
> There isn't any common code in this function.
> Why not break into _SwapFirefoxProfile and _SwapSafariProfile?

Beforehand I was anticipating a lot tests that would import from multiple
browsers and thought a single function call would be nice. But I agree - it's
better to split.

http://codereview.chromium.org/3140011/diff/27001/28001
File chrome/test/data/import/README (right):

http://codereview.chromium.org/3140011/diff/27001/28001#newcode22
chrome/test/data/import/README:22: TODO(alyssad): In the future, add search
engines.
On 2010/08/26 00:34:05, Nirnimesh wrote:
> The new First Run UI doesn't import search engines, since it asks the user for
> the search engine to use. Remove this line.

I think this is different. It's for keyword searches.

http://codereview.chromium.org/3140011/diff/27001/28005
File chrome/test/functional/imports.py (right):

http://codereview.chromium.org/3140011/diff/27001/28005#newcode23
chrome/test/functional/imports.py:23: """ Import settings from other browsers.
On 2010/08/26 00:34:05, Nirnimesh wrote:
> Remove space after """

Done.

http://codereview.chromium.org/3140011/diff/27001/28005#newcode65
chrome/test/functional/imports.py:65: """Unzip |profile_zip| into directory
|dir|."""
On 2010/08/26 00:34:05, Nirnimesh wrote:
> add a comment mentioning that it creates |dir| if it doesn't exist.

Done.

http://codereview.chromium.org/3140011/diff/27001/28005#newcode96
chrome/test/functional/imports.py:96: # TODO(alyssad): Add ie when the profile
and tests are ready.
On 2010/08/26 00:34:05, Nirnimesh wrote:
> s/ie/IE/

Done.

http://codereview.chromium.org/3140011/diff/27001/28005#newcode123
chrome/test/functional/imports.py:123: shutil.rmtree(profile_dir)
On 2010/08/26 00:34:05, Nirnimesh wrote:
> you don't need this and next line.
> ExistingPathReplacer creates an empty dir for you, while backing up (if
> required)

Done.

http://codereview.chromium.org/3140011/diff/27001/28005#newcode132
chrome/test/functional/imports.py:132: del self._replacer
On 2010/08/26 00:34:05, Nirnimesh wrote:
> Add a comment.
> del self._replacer  # Reinstates original profile dir (if any).

Done.

http://codereview.chromium.org/3140011/diff/27001/28005#newcode166
chrome/test/functional/imports.py:166: """Check if the list of history items are
in the history.
On 2010/08/26 00:34:05, Nirnimesh wrote:
> s/Check if the/Verifies that the given/

Done.

http://codereview.chromium.org/3140011/diff/27001/28005#newcode173
chrome/test/functional/imports.py:173: confirmed_history_titles = set()
On 2010/08/26 00:34:05, Nirnimesh wrote:
> why do we need the set here?
> we can simple assert that the title exists in history in linfe 176
> 
> for title in history_titles:
>   self.assertTrue([x for x in history if x['title'] == title])

Yep, much better.

http://codereview.chromium.org/3140011/diff/27001/28005#newcode182
chrome/test/functional/imports.py:182: # Password imports do not work on Mac.
See crbug.com/52124.
On 2010/08/26 00:34:05, Nirnimesh wrote:
> s/password imports/password import automation/

Done.

http://codereview.chromium.org/3140011/diff/27001/28005#newcode186
chrome/test/functional/imports.py:186: confirmed_usernames = set()
On 2010/08/26 00:34:05, Nirnimesh wrote:
> this too can be shortened like above

Done.

http://codereview.chromium.org/3140011/diff/27001/28005#newcode199
chrome/test/functional/imports.py:199: self._CheckForBookmarks(set(['Google
News']), True)
On 2010/08/26 00:34:05, Nirnimesh wrote:
> does it have to be a set? a list won't do?

Done. List works now.

http://codereview.chromium.org/3140011/diff/27001/28005#newcode200
chrome/test/functional/imports.py:200: self._CheckForBookmarks(set(['Google',
u'Google \ub3c4\uc11c']), False)
On 2010/08/26 00:34:05, Nirnimesh wrote:
> use a member variable like that for history

Done.

http://codereview.chromium.org/3140011/diff/27001/28005#newcode211
chrome/test/functional/imports.py:211: def testFirefoxPreferences(self):
On 2010/08/26 00:34:05, Nirnimesh wrote:
> this sounds like it's a test for firefox preferences.
> rename to testFirefoxImportFromPrefs

Done.

http://codereview.chromium.org/3140011/diff/27001/28005#newcode232
chrome/test/functional/imports.py:232: def testImportFromFirefoxAndSafari(self):
On 2010/08/26 00:34:05, Nirnimesh wrote:
> Please break it out into a separate test for FF and Safari

I thought they sent me this test because we wanted a test that imported from
both. If not, then we can remove this test entirely since we already have tests
which cover this for FF and Safari individually.

http://codereview.chromium.org/3140011/diff/27001/28005#newcode261
chrome/test/functional/imports.py:261: set(['Google', 'Google News', u'Google
\ub3c4\uc11c'])))
On 2010/08/26 00:34:05, Nirnimesh wrote:
> use this data from a member variable defined in __init__

Done.

http://codereview.chromium.org/3140011/diff/27001/28005#newcode266
chrome/test/functional/imports.py:266: def testSafariPreferences(self):
On 2010/08/26 00:34:05, Nirnimesh wrote:
> rename: testSafariImportFromPrefs

Done.

http://codereview.chromium.org/3140011/diff/27001/28005#newcode303
chrome/test/functional/imports.py:303: set(['Google', 'Google News', u'Google
\ub3c4\uc11c'])))
On 2010/08/26 00:34:05, Nirnimesh wrote:
> use this data from a preset member var

Done.

[Nirnimesh, 2010-08-26 01:27:37]

LGTM.

(Please check in at a time when you can observe the pyauto bots.)

http://codereview.chromium.org/3140011/diff/27001/28005
File chrome/test/functional/imports.py (right):

http://codereview.chromium.org/3140011/diff/27001/28005#newcode232
chrome/test/functional/imports.py:232: def testImportFromFirefoxAndSafari(self):
Oh yeah, my bad. Never mind.

[Alyssa, 2010-08-26 18:39:57]

Can you take one more look at the final changes? I needed to make a different
replacer object for each profile.

[Nirnimesh, 2010-08-26 18:49:56]

http://codereview.chromium.org/3140011/diff/38001/39001
File chrome/test/data/import/README (right):

http://codereview.chromium.org/3140011/diff/38001/39001#newcode22
chrome/test/data/import/README:22: TODO(alyssad): In the future, add search
engines.
Remove this line too. We won't import search engines.

http://codereview.chromium.org/3140011/diff/38001/39005
File chrome/test/functional/imports.py (right):

http://codereview.chromium.org/3140011/diff/38001/39005#newcode130
chrome/test/functional/imports.py:130: self._replacer =
pyauto_utils.ExistingPathReplacer(profile_dir)
We have replacers for each profile above. What is this replacer for?

http://codereview.chromium.org/3140011/diff/38001/39005#newcode135
chrome/test/functional/imports.py:135: self.CloseBrowserAndServer()
why?

http://codereview.chromium.org/3140011/diff/38001/39005#newcode136
chrome/test/functional/imports.py:136: os.path.exists(profile_dir) and
shutil.rmtree(profile_dir)
you should del self._replacer here

[Alyssa, 2010-08-26 18:56:05]

http://codereview.chromium.org/3140011/diff/38001/39005
File chrome/test/functional/imports.py (right):

http://codereview.chromium.org/3140011/diff/38001/39005#newcode130
chrome/test/functional/imports.py:130: self._replacer =
pyauto_utils.ExistingPathReplacer(profile_dir)
On 2010/08/26 18:49:56, Nirnimesh wrote:
> We have replacers for each profile above. What is this replacer for?

I meant to remove this call entirely.

http://codereview.chromium.org/3140011/diff/38001/39005#newcode135
chrome/test/functional/imports.py:135: self.CloseBrowserAndServer()
On 2010/08/26 18:49:56, Nirnimesh wrote:
> why?

Commented. When I didn't do this I had issues where there was a lock on the
directory and it couldn't be deleted.

http://codereview.chromium.org/3140011/diff/38001/39005#newcode136
chrome/test/functional/imports.py:136: os.path.exists(profile_dir) and
shutil.rmtree(profile_dir)
On 2010/08/26 18:49:56, Nirnimesh wrote:
> you should del self._replacer here

Since I removed the method that creates it, this is no longer necessary.

[Nirnimesh, 2010-08-26 19:01:40]

http://codereview.chromium.org/3140011/diff/38001/39005
File chrome/test/functional/imports.py (right):

http://codereview.chromium.org/3140011/diff/38001/39005#newcode135
chrome/test/functional/imports.py:135: self.CloseBrowserAndServer()
Don't just comment. Please remove it

[Nirnimesh, 2010-08-26 19:02:34]

http://codereview.chromium.org/3140011/diff/38001/39005
File chrome/test/functional/imports.py (right):

http://codereview.chromium.org/3140011/diff/38001/39005#newcode135
chrome/test/functional/imports.py:135: self.CloseBrowserAndServer()
maybe I misunderstood. please upload new patch

[Nirnimesh, 2010-08-26 20:28:29]

LGTM. Thanks for doing the weightlifting.

http://codereview.chromium.org/3140011/diff/26002/33006
File chrome/test/functional/imports.py (right):

http://codereview.chromium.org/3140011/diff/26002/33006#newcode72
chrome/test/functional/imports.py:72: # Delete any replacers that were created
to restore the original profiles.
delete "that were created"

[Nico, 2010-08-27 04:11:41]

Guys. Please don't check in 15 MB of binary data. Pull that through deps. Please
revert this.

[viettrungluu, 2010-08-27 04:15:22]

Alyssa, Nirnimesh:

Please do not check large binaries into trunk; this makes git users miserable
(unfortunately, simply reverting won't help).

Evan: Are we doing anything about this sort of thing these days?

- Trung

[Alyssa, 2010-08-27 04:21:03]

So sorry, I guess I didn't think about that - what can I do about this now if
revert won't help?

[viettrungluu, 2010-08-27 04:29:27]

On 2010/08/27 04:21:03, Alyssa wrote:
> So sorry, I guess I didn't think about that - what can I do about this now if
> revert won't help?

Let's wait for Evan to reply. Probably we'll want to revert or remove these
files and pull them via DEPS from another location. (Eventually, we may be able
to clean them out.) But I don't think there's any particular rush.

[Evan Martin, 2010-08-27 22:48:24]

On 2010/08/27 04:29:27, viettrungluu wrote:
> On 2010/08/27 04:21:03, Alyssa wrote:
> > So sorry, I guess I didn't think about that - what can I do about this now
if
> > revert won't help?
> 
> Let's wait for Evan to reply. Probably we'll want to revert or remove these
> files and pull them via DEPS from another location. (Eventually, we may be
able
> to clean them out.) But I don't think there's any particular rush.

Ah yes, I was wondering why my update today was so huge.
Reverting won't help.
You can at least help SVN users in the future though:

1) Move the whole directory to:
  http://src.chromium.org/viewvc/chrome/trunk/deps/
Perhaps refactoring by platform rather than browser

2) Set up platform-specific checkouts by following the pattern in DEPS in the
Chrome root.  (Search for deps_os, it's pretty simple.)