Chromium Code Reviews
Help | Chromium Project | Sign in
(10)

Issue 3140001: Mac: Highlight selected tile in tabpose. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by Nico
Modified:
4 years ago
CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Mac: Highlight selected tile in tabpose. BUG=50307 TEST=selected tile now has a blue border TBR=trungl Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55505

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -18 lines) Patch
M chrome/browser/cocoa/tabpose_window.h View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/cocoa/tabpose_window.mm View 7 chunks +27 lines, -17 lines 1 comment Download
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
Nico
4 years, 9 months ago (2010-08-09 23:19:54 UTC) #1
Nico
TBRing since it's a very boring cl
4 years, 9 months ago (2010-08-09 23:43:57 UTC) #2
viettrungluu
4 years, 9 months ago (2010-08-10 00:42:33 UTC) #3
LGTM

http://codereview.chromium.org/3140001/diff/1/3
File chrome/browser/cocoa/tabpose_window.mm (right):

http://codereview.chromium.org/3140001/diff/1/3#newcode400
chrome/browser/cocoa/tabpose_window.mm:400:
darkBlue_.reset(CGColorCreateGenericRGB(0.25, 0.34, 0.86, 1.0));
Out of which orifice did you get these numbers? :P
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be