Issue 3140001: Mac: Highlight selected tile in tabpose.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3140001: Mac: Highlight selected tile in tabpose. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 9 months ago by Nico

Modified:
4 years ago

Reviewers:
Robert Sesek, viettrungluu

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Description

Mac: Highlight selected tile in tabpose. BUG=50307 TEST=selected tile now has a blue border TBR=trungl Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55505

Patch Set 1 #

Total comments: 1

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -18 lines)			Patch
	M	chrome/browser/cocoa/tabpose_window.h	View		1 chunk	+6 lines, -1 line	0 comments	Download
	M	chrome/browser/cocoa/tabpose_window.mm	View		7 chunks	+27 lines, -17 lines	1 comment	Download

Trybot results: mac linux win

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

4 years, 9 months ago (2010-08-10 00:42:33 UTC) #3

LGTM

http://codereview.chromium.org/3140001/diff/1/3
File chrome/browser/cocoa/tabpose_window.mm (right):

http://codereview.chromium.org/3140001/diff/1/3#newcode400
chrome/browser/cocoa/tabpose_window.mm:400:
darkBlue_.reset(CGColorCreateGenericRGB(0.25, 0.34, 0.86, 1.0));
Out of which orifice did you get these numbers? :P

Expand Messages | Collapse Messages