[Telemetry] Overhaul startup metric.

[Telemetry] Overhaul startup metric.

This focuses us on the user-perceived aspects of startup.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275194

[jeremy, 2014-06-05 10:55:22]

LGTM

https://codereview.chromium.org/313993003/diff/1/tools/perf/metrics/startup_m...
File tools/perf/metrics/startup_metric.py (right):

https://codereview.chromium.org/313993003/diff/1/tools/perf/metrics/startup_m...
tools/perf/metrics/startup_metric.py:70: return foreground_tab_load_time,
all_tabs_load_time
nit: if you're returning a tuple then

return (a, b)

?

[tonyg, 2014-06-05 16:50:00]

https://codereview.chromium.org/313993003/diff/1/tools/perf/metrics/startup_m...
File tools/perf/metrics/startup_metric.py (right):

https://codereview.chromium.org/313993003/diff/1/tools/perf/metrics/startup_m...
tools/perf/metrics/startup_metric.py:70: return foreground_tab_load_time,
all_tabs_load_time
On 2014/06/05 10:55:22, jeremy wrote:
> nit: if you're returning a tuple then
> 
> return (a, b)
> 
> ?

The style guide says the parens here are fine, but to use the sparingly. I'm
just going to omit them.

http://google-styleguide.googlecode.com/svn/trunk/pyguide.html?showone=Parent...

[tonyg, 2014-06-05 16:50:04]

The CQ bit was checked by tonyg@chromium.org

[commit-bot: I haz the power, 2014-06-05 16:52:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tonyg@chromium.org/313993003/1

[commit-bot: I haz the power, 2014-06-05 18:15:51]

Change committed as 275194

[tonyg, 2014-06-06 05:30:25]

A revert of this CL has been created in
https://codereview.chromium.org/317743003/ by tonyg@chromium.org.

The reason for reverting is: Other patches need to land before this. This broke
bots..